From: "Jan Beulich" <JBeulich@suse.com>
To: "Arnaldo Carvalho de Melo" <acme@redhat.com>
Cc: "Arnaldo Carvalho de Melo" <acme@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: your recent tools/include/ adjustments
Date: Tue, 13 Jan 2015 15:56:28 +0000 [thread overview]
Message-ID: <54B54E3C0200007800054741@mail.emea.novell.com> (raw)
In-Reply-To: <20150113132912.GA2468@redhat.com>
>>> On 13.01.15 at 14:29, <acme@redhat.com> wrote:
> Em Tue, Jan 13, 2015 at 08:48:35AM +0000, Jan Beulich escreveu:
>> Arnaldo,
>>
>> considering that tools/include/ gets used by other than just perf, in
>> particular arch/x86/vdso/vdso2c.c, would you mind clarifying how
>> "tools: Move bitops.h from tools/perf/util to tools/" adding an
>> inclusion of asm/hweight.h to linux/bitops.h is supposed to work,
>> when the only potentially relevant header to be found is
>> tools/perf/util/include/asm/hweight.h?
>
> Oops, includes are tricky, even more so when trying to reuse the kernel
> ones in tools/, so we need to go on addressing these problems, thanks
> for reporting.
>
> Please take a look if the patch at the end addresses this problem, I
> think it should at least disentangle what is in tools/include from what
> is in tools/perf/.
It looks like it would fix the issue - thanks for the quick response.
Jan
prev parent reply other threads:[~2015-01-13 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 8:48 Jan Beulich
2015-01-13 13:29 ` Arnaldo Carvalho de Melo
2015-01-13 15:56 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B54E3C0200007800054741@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®