From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH v2 2/4] perf tools: Add link argument to dso__find_symbol_by_name()
Date: Wed, 14 Jan 2015 17:42:41 -0700 [thread overview]
Message-ID: <54B70D01.2050309@gmail.com> (raw)
In-Reply-To: <20150115002359.GB2096@sejong>
On 1/14/15 5:23 PM, Namhyung Kim wrote:
> On Wed, Jan 14, 2015 at 09:36:34AM -0700, David Ahern wrote:
>>> + /* return first symbol that has same name (if any) */
>>> + for (n = rb_prev(n); n; n = rb_prev(n)) {
>>> + struct symbol_name_rb_node *tmp;
>>> +
>>> + tmp = rb_entry(n, struct symbol_name_rb_node, rb_node);
>>> + if (strcmp(tmp->sym.name, s->sym.name))
>>
>> strcmp() == 0?
>
> No, at this point the 's' points to the first symbol that has same
> name. And if it finds another symbol (tmp) that has same name, it
> updates the s to point to the tmp and continues. Otherwise it returns
> with the existing symbol (s).
I squinted a bit harder at your v3 and realized that. Was not obvious
based on the first reading of the loop.
David
next prev parent reply other threads:[~2015-01-15 0:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 11:18 [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI Namhyung Kim
2015-01-14 11:18 ` [PATCH v2 2/4] perf tools: Add link argument to dso__find_symbol_by_name() Namhyung Kim
2015-01-14 16:36 ` David Ahern
2015-01-15 0:23 ` Namhyung Kim
2015-01-15 0:42 ` David Ahern [this message]
2015-01-28 15:01 ` [tip:perf/core] perf symbols: Return the first entry with a given name in find_by_name method tip-bot for Namhyung Kim
2015-01-14 11:18 ` [PATCH v2 3/4] perf probe: Do not rely on map__load() filter to find symbols Namhyung Kim
2015-01-14 13:54 ` Arnaldo Carvalho de Melo
2015-01-15 12:09 ` Masami Hiramatsu
2015-01-28 15:02 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-01-14 11:18 ` [PATCH v2 4/4] perf probe: Fix probing kretprobes Namhyung Kim
2015-01-14 16:26 ` Jiri Olsa
2015-01-15 12:11 ` Masami Hiramatsu
2015-01-28 15:02 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-01-14 12:57 ` [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI Arnaldo Carvalho de Melo
2015-01-14 14:57 ` David Ahern
2015-01-14 21:08 ` Arnaldo Carvalho de Melo
2015-01-15 0:20 ` Namhyung Kim
2015-01-17 12:38 ` Arnaldo Carvalho de Melo
2015-01-17 10:13 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B70D01.2050309@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome