From: Shuah Khan <shuahkh@osg.samsung.com>
To: m.chehab@samsung.com, hans.verkuil@cisco.com,
dheitmueller@kernellabs.com, prabhakar.csengg@gmail.com,
sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
ttmesterr@gmail.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] media: au0828 - convert to use videobuf2
Date: Wed, 28 Jan 2015 16:14:20 -0700 [thread overview]
Message-ID: <54C96D4C.6070200@osg.samsung.com> (raw)
In-Reply-To: <1422042075-7320-1-git-send-email-shuahkh@osg.samsung.com>
On 01/23/2015 12:41 PM, Shuah Khan wrote:
> Convert au0828 to use videobuf2. Tested with NTSC.
> Tested video and vbi devices with xawtv, tvtime,
> and vlc. Ran v4l2-compliance to ensure there are
> no failures.
>
> Video compliance test results summary:
> Total: 75, Succeeded: 75, Failed: 0, Warnings: 18
>
> Vbi compliance test results summary:
> Total: 75, Succeeded: 75, Failed: 0, Warnings: 0
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
Hi Hans,
Please don't pull this in. Found a bug in stop_streaming() when
re-tuning that requires re-working this patch.
stop_streaming() calls is doing more than it should while
holding slock triggering lock warning.
It shouldn't call
v4l2_device_call_all(&dev->v4l2_dev, 0, video, s_stream, 0);
while holding slock triggering lock warning.
I will send patch v6.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-01-29 1:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 19:41 Shuah Khan
2015-01-28 23:14 ` Shuah Khan [this message]
2015-01-29 11:13 ` Davidlohr Bueso
2015-01-29 11:15 ` Hans Verkuil
2015-01-29 11:21 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C96D4C.6070200@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=dheitmueller@kernellabs.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=ttmesterr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®