Re: [PATCH v5] media: au0828 - convert to use videobuf2

[Hans Verkuil <hansverk@cisco.com>]

On 01/29/15 12:13, Davidlohr Bueso wrote:
> On Wed, 2015-01-28 at 16:14 -0700, Shuah Khan wrote:
>> On 01/23/2015 12:41 PM, Shuah Khan wrote:
>>> Convert au0828 to use videobuf2. Tested with NTSC.
>>> Tested video and vbi devices with xawtv, tvtime,
>>> and vlc. Ran v4l2-compliance to ensure there are
>>> no failures. 
>>>
>>> Video compliance test results summary:
>>> Total: 75, Succeeded: 75, Failed: 0, Warnings: 18
>>>
>>> Vbi compliance test results summary:
>>> Total: 75, Succeeded: 75, Failed: 0, Warnings: 0
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>
>> Hi Hans,
>>
>> Please don't pull this in. Found a bug in stop_streaming() when
>> re-tuning that requires re-working this patch.
> 
> ... and also:
> 
>  drivers/media/usb/au0828/Kconfig        |   2 +-
>  drivers/media/usb/au0828/au0828-vbi.c   | 122 ++--
>  drivers/media/usb/au0828/au0828-video.c | 962 ++++++++++++--------------------
>  drivers/media/usb/au0828/au0828.h       |  61 +-
>  4 files changed, 443 insertions(+), 704 deletions(-)
> 
> in a single patch. Lets be nice to reviewers, we can spare a few extra
> hash ids.

You can't split this up, it's one of those changes that is all or
nothing.

Regards,

	Hans