* [PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used
@ 2015-01-28 22:37 Rickard Strandqvist
2015-01-29 14:44 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-28 22:37 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten
Cc: Rickard Strandqvist, Greg Kroah-Hartman, devel, linux-kernel
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/comedi/drivers/ni_atmio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index 0c5ff28..301f154 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -300,7 +300,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
{
const struct ni_board_struct *boardtype;
- struct ni_private *devpriv;
struct pnp_dev *isapnp_dev;
int ret;
unsigned long iobase;
@@ -310,7 +309,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
ret = ni_alloc_private(dev);
if (ret)
return ret;
- devpriv = dev->private;
iobase = it->options[0];
irq = it->options[1];
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used
2015-01-28 22:37 [PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used Rickard Strandqvist
@ 2015-01-29 14:44 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2015-01-29 14:44 UTC (permalink / raw)
To: Rickard Strandqvist, H Hartley Sweeten
Cc: Greg Kroah-Hartman, devel, linux-kernel
On 28/01/15 22:37, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 0c5ff28..301f154 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -300,7 +300,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
> struct comedi_devconfig *it)
> {
> const struct ni_board_struct *boardtype;
> - struct ni_private *devpriv;
> struct pnp_dev *isapnp_dev;
> int ret;
> unsigned long iobase;
> @@ -310,7 +309,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
> ret = ni_alloc_private(dev);
> if (ret)
> return ret;
> - devpriv = dev->private;
>
> iobase = it->options[0];
> irq = it->options[1];
>
Yes, devpriv is no longer needed here.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 22:37 [PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used Rickard Strandqvist
2015-01-29 14:44 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®