mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>, Keith Busch <keith.busch@intel.com>
Cc: Dongsu Park <dongsu.park@profitbricks.com>,
	dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm: fix multipath regression due to initializing wrong request
Date: Mon, 09 Feb 2015 10:47:19 -0700	[thread overview]
Message-ID: <54D8F2A7.6050501@kernel.dk> (raw)
In-Reply-To: <20150209173514.GA14199@redhat.com>

On 02/09/2015 10:35 AM, Mike Snitzer wrote:
> On Mon, Feb 09 2015 at 12:13P -0500,
> Mike Snitzer <snitzer@redhat.com> wrote:
>
>> On Mon, Feb 09 2015 at 12:07pm -0500,
>> Keith Busch <keith.busch@intel.com> wrote:
>>
>>> Oh, we're not going rebase the series with the correction? I'm concerned
>>> someone biscecting a completely unrelated problem might step on this
>>> commit. Up to you guys. It's my fault, so I'll deal with the consequences.
>>
>> Rebasing this late (3.20 merge already opened) is generally not done.
>> Unfortunately we'll just have to suck it up and deal with the fallout
>> during bisect -- would wager very few are bisecting with multipath as
>> the focus of their test.
>
> Jens and I discussed this further and given that linux-block breaks
> dm-multipath it is best to fix linux-block and let Linus resolve the
> merge when I send him the linux-dm pull.
>
> Here is the patch to fix the regression:

Added, thanks. I don't think this is worth rebasing for, so just added 
to the top of for-3.20/core (since that's where the buggy commit was added).

-- 
Jens Axboe


  reply	other threads:[~2015-02-09 17:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 16:38 blk-mq crash with dm-multipath in for-3.20/core Dongsu Park
2015-02-09 16:48 ` Mike Snitzer
2015-02-09 17:07   ` Keith Busch
2015-02-09 17:13     ` Mike Snitzer
2015-02-09 17:35       ` [PATCH] dm: fix multipath regression due to initializing wrong request Mike Snitzer
2015-02-09 17:47         ` Jens Axboe [this message]
2015-02-10 10:42           ` Dongsu Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D8F2A7.6050501@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=dongsu.park@profitbricks.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®