mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Timur Tabi <timur@tabi.org>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Xiubo Li <Li.Xiubo@freescale.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
Date: Wed, 04 Mar 2015 14:07:21 +0100	[thread overview]
Message-ID: <54F70389.6020004@maciej.szmigiero.name> (raw)
In-Reply-To: <20150224082448.GY6236@finisterre.sirena.org.uk>

W dniu 24.02.2015 09:24, Mark Brown pisze:
> On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote:
>> of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice,
>> first on assignment then in condition expression.
> 
> This doesn't apply to current code, please check and resend.  Please
> also keep your changelog under 80 columns as covered in
> SubmittingPatches.
> 

Thanks for looking into it,

Against which tree/branch patches for ASoC should be generated?

Best regards,
Maciej Szmigiero


  reply	other threads:[~2015-03-04 13:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-15 22:11 Maciej S. Szmigiero
2015-02-24  8:24 ` Mark Brown
2015-03-04 13:07   ` Maciej S. Szmigiero [this message]
2015-03-04 17:27     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F70389.6020004@maciej.szmigiero.name \
    --to=mail@maciej.szmigiero.name \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®