From: "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
To: "joro@8bytes.org" <joro@8bytes.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"Singh, Brijesh" <brijesh.singh@amd.com>
Subject: Re: [PATCH] iommu/amd: Fix IOMMU page flush when detach all devices from a domain
Date: Thu, 24 Jan 2019 03:25:19 +0000 [thread overview]
Message-ID: <54a1da19-54dd-30cc-191b-7fe5dc4a58fa@amd.com> (raw)
In-Reply-To: <20190123075658.GE32526@8bytes.org>
Joerg,
On 1/23/19 2:56 PM, joro@8bytes.org wrote:
> Hi Suravee,
>
> On Tue, Jan 22, 2019 at 03:53:18PM +0000, Suthikulpanit, Suravee wrote:
>> Thanks for the detail. Alright then, let's just go with the version you
>> sent on 1/16/19. Do you want me to resend V3 with that changes, or
>> would you be taking care of that?
>
> Please send me a v3 based on the diff I sent last week. Also add a
> separate patch which adds the missing dte flush for the alias entry.
>
> Thanks,
>
> Joerg
>
Actually, I just noticed that device_flush_dte() has already handled flushing the DTE
for alias device as well. Please see the link below.
https://elixir.bootlin.com/linux/latest/source/drivers/iommu/amd_iommu.c#L1219
So, we don't need to call device_flush_dte() for alias device in do_detach().
Regards,
Suravee
next prev parent reply other threads:[~2019-01-24 3:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 4:16 Suthikulpanit, Suravee
2019-01-16 13:26 ` joro
2019-01-16 14:08 ` Suthikulpanit, Suravee
2019-01-16 17:08 ` joro
2019-01-17 8:44 ` Suthikulpanit, Suravee
2019-01-17 11:48 ` Suthikulpanit, Suravee
2019-01-22 10:44 ` joro
2019-01-22 15:53 ` Suthikulpanit, Suravee
2019-01-23 7:56 ` joro
2019-01-24 3:25 ` Suthikulpanit, Suravee [this message]
2019-01-24 8:04 ` joro
2019-01-16 14:40 ` Suthikulpanit, Suravee
2019-01-16 17:09 ` joro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54a1da19-54dd-30cc-191b-7fe5dc4a58fa@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome