From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Arnd Bergmann <arnd@arndb.de>, Wolfgang Grandegger <wg@grandegger.com>
Cc: Mario Huettel <mario.huettel@gmx.net>,
Faiz Abbas <faiz_abbas@ti.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
Franklin S Cooper Jr <fcooper@ti.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused
Date: Thu, 18 Jan 2018 14:16:37 +0100 [thread overview]
Message-ID: <54b08b88-493f-a39e-db00-194ba91dcedf@pengutronix.de> (raw)
In-Reply-To: <20180118130513.506569-1-arnd@arndb.de>
[-- Attachment #1.1: Type: text/plain, Size: 951 bytes --]
On 01/18/2018 02:04 PM, Arnd Bergmann wrote:
> Building without CONFIG_PM results in a harmless warning:
>
> drivers/net/can/m_can/m_can.c:1763:12: error: 'm_can_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/net/can/m_can/m_can.c:1752:12: error: 'm_can_runtime_suspend' defined but not used [-Werror=unused-function]
>
> Marking the functions as __maybe_unused lets the compiler
> silently drop them instead.
>
> Fixes: cdf8259d6573 ("can: m_can: Add PM Support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tnx - applied.
However all archs using this driver have mandatory PM support and the
driver depends on it.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-01-18 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 13:04 Arnd Bergmann
2018-01-18 13:16 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54b08b88-493f-a39e-db00-194ba91dcedf@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=arnd@arndb.de \
--cc=faiz_abbas@ti.com \
--cc=fcooper@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.huettel@gmx.net \
--cc=netdev@vger.kernel.org \
--cc=quentin.schulz@free-electrons.com \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®