From: David Arcari <darcari@redhat.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [v2] intel_th: core: fix null pointer dereference in intel_th_irq
Date: Thu, 20 Nov 2025 08:22:55 -0500 [thread overview]
Message-ID: <54ffe25e-c697-4639-b405-af50416764c8@redhat.com> (raw)
In-Reply-To: <0d5bad33-49ed-4531-b399-e548d3dfce66@web.de>
On 11/20/25 8:07 AM, Markus Elfring wrote:
> …>>> the same array. This can be fixed by disabling interrupts
>>>> during the call to intel_th_output_enable().
>>>
>>> 1. Would another imperative wording become helpful for an improved change description?
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94
>>
>> I feel like the description explains the problem well.
>
> Perhaps?
>
>
>> However, do you have alternate wording you would like to suggest?
>
> Under which circumstances would you get into the mood to convert the wording approach
> “can be fixed by” into an imperative one?
I see. I will make that change if a v3 is in order. Naturally, I'd like
to hear back from Alexander before putting more effort into this.
Best,
-DA
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2025-11-20 13:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 17:45 [PATCH] " David Arcari
2025-09-04 17:41 ` David Arcari
2025-09-26 16:19 ` alex
2025-09-26 20:12 ` David Arcari
2025-09-27 14:54 ` Markus Elfring
2025-09-29 12:05 ` David Arcari
2025-11-18 21:21 ` [PATCH v2] " David Arcari
2025-11-19 12:55 ` Markus Elfring
2025-11-20 12:32 ` David Arcari
2025-11-20 13:07 ` [v2] " Markus Elfring
2025-11-20 13:22 ` David Arcari [this message]
2026-01-16 12:49 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ffe25e-c697-4639-b405-af50416764c8@redhat.com \
--to=darcari@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®