mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Slark Xiao" <slark_xiao@163.com>
To: "Manivannan Sadhasivam" <mani@kernel.org>
Cc: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
	jeff.hugo@oss.qualcomm.com, mhi@lists.linux.dev,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] bus: mhi: host: pci_generic: Add autosuspend_delay customized support
Date: Thu, 8 Oct 2026 16:40:09 +0800 (CST)	[thread overview]
Message-ID: <5506abc6.8919.1a11aab7e81.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <nsaa4cchprkgqka7uc4ccr5wq7v6uhue5dpsvquwxyk4ndr57t@i56bkvwpclpo>



At 2026-09-26 19:26:15, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
>On Wed, Sep 23, 2026 at 09:24:55AM +0530, Krishna Chaitanya Chundru wrote:
>> 
>> 
>> On 9/22/2026 5:09 PM, Slark Xiao wrote:
>> > At 2026-09-22 12:12:35, "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com> wrote:
>> >>
>> >> On 9/19/2026 3:25 PM, Slark Xiao wrote:
>> >>> For some WWAN device, it may get a SYS ERROR issue when resuming
>> >>> from suspend state frequently. Refer to the Qualcomm Windows
>> >>> driver, the default value of autosuspend_delay_ms is set as 5000
>> >>> ms. But in Linux side, all WWAN device were set as 2000ms. We
>> >>> tried to set this value to 5000ms and we can get a positive test
>> >>> result.
>> >>>
>> >>> So we add a support to allow vendor to set a difference value for
>> >>> specific WWAN device.
>> >> you can change auto suspend delay from sysfs, please use that way instead of
>> >> doing in the driver.
>> >>
>> >> - Krishna Chaitanya.
>> > Yes, we can do this by setting the sysfs API . However, not all users 
>> > are aware of this method. Additionally, this approach is only
>> > effective for a single instance; it requires reconfiguration after each
>> > restart, which is quite inconvenient.
>> you can have udev rule to set this without any user intervention.
>
>We should not rely on userspace to fix the SYS_ERROR. Userspace knob should only
>be exercised to customize the delay for power management purposes, not to fix
>firmware crash.

>
Agree. We are still working on the issue debug on the modem side. 

>First we should know whether the default delay can be increased to 5000ms for
>all devices or not. If that is not desired, then we can go for Endpoint specific
>delay.
>
>- Mani
>
For reference, MTK 5G modem T700 is using 5000ms as default value. And Qualcomm
Windows drivers side, the default value is 5000ms as well.
However, I cannot guarantee that if all MHI devices are adjusted to 5000ms, some
power-sensitive devices will not oppose this change. Additional, DELL hopes that
we only modify the SDX72 device while keeping the 2000ms setting for the SDX62
devices, as there are currently no similar issues with the SDX62 platform.

If endpoint specific delay setting is acceptable, I will commit a V2 which includes
some specific changes for DW5934e devices only.

Thanks
>-- 
>மணிவண்ணன் சதாசிவம்

  reply	other threads:[~2026-10-08  8:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19  9:55 Slark Xiao
2026-09-22  4:12 ` Krishna Chaitanya Chundru
2026-09-22 11:39   ` Slark Xiao
2026-09-23  3:54     ` Krishna Chaitanya Chundru
2026-09-23  9:49       ` Slark Xiao
2026-09-26 11:26       ` Manivannan Sadhasivam
2026-10-08  8:40         ` Slark Xiao [this message]
2026-10-11  9:46           ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5506abc6.8919.1a11aab7e81.Coremail.slark_xiao@163.com \
    --to=slark_xiao@163.com \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®