From: Woody Suwalski <terraluna977@gmail.com>
To: Daniel Vetter <daniel.vetter@intel.com>
Cc: Sinclair Yeh <syeh@vmware.com>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@linux.ie>
Subject: Re: [PATCH v.2] 4.15 vmgfx boot warning
Date: Mon, 18 Dec 2017 19:26:03 -0500 [thread overview]
Message-ID: <5508ddeb-ef4d-abfa-2573-717066448a43@gmail.com> (raw)
In-Reply-To: <1d88409f-23c4-6706-7111-00f2d13f3351@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
The 4.15 drm_atomic_helper driver shows a warning during boot (both 32
and 64 bit x86)
It is caused by a mismatch between the result of vmw_enable_vblank() and
what the drm_atomic_helper expects:
/...
ret = drm_crtc_vblank_get(crtc);
WARN_ONCE(ret != -EINVAL, "driver forgot to call
drm_crtc_vblank_off()\n");
/...
Signed-off by: Woody Suwalski <terraluna977@gmail.com>
--- a/drivers/gpu/drm/drm_atomic_helper.c 2017-12-16
09:55:33.853374561 -0500
+++ b/drivers/gpu/drm/drm_atomic_helper.c 2017-12-16
10:55:56.089090752 -0500
@@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,
continue;
ret = drm_crtc_vblank_get(crtc);
- WARN_ONCE(ret != -EINVAL, "driver forgot to call
drm_crtc_vblank_off()\n");
+ WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to
call drm_crtc_vblank_off()\n");
if (ret == 0)
drm_crtc_vblank_put(crtc);
}
[-- Attachment #2: 040_drm_atomic_helper.patch --]
[-- Type: text/x-patch, Size: 498 bytes --]
--- a/drivers/gpu/drm/drm_atomic_helper.c 2017-12-16 09:55:33.853374561 -0500
+++ b/drivers/gpu/drm/drm_atomic_helper.c 2017-12-16 10:55:56.089090752 -0500
@@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,
continue;
ret = drm_crtc_vblank_get(crtc);
- WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n");
+ WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to call drm_crtc_vblank_off()\n");
if (ret == 0)
drm_crtc_vblank_put(crtc);
}
next prev parent reply other threads:[~2017-12-19 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 21:05 [PATCH] " Woody Suwalski
2017-12-13 21:25 ` Sinclair Yeh
2017-12-16 0:01 ` Woody Suwalski
2017-12-19 0:26 ` Woody Suwalski [this message]
2017-12-19 19:50 ` [PATCH v.2] " Sinclair Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5508ddeb-ef4d-abfa-2573-717066448a43@gmail.com \
--to=terraluna977@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syeh@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome