From: Woody Suwalski <terraluna977@gmail.com>
To: Sinclair Yeh <syeh@vmware.com>
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@linux.ie>
Subject: [PATCH] 4.15 vmgfx boot warning
Date: Wed, 22 Nov 2017 16:05:50 -0500 [thread overview]
Message-ID: <c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com> (raw)
The 4.15 vmwgfx driver shows a warning during boot (32 bit x86)
It is caused by a mismatch between the result of vmw_enable_vblank() and
what the drm_atomic_helper expects:
/...
ret = drm_crtc_vblank_get(crtc);
WARN_ONCE(ret != -EINVAL, "driver forgot to call
drm_crtc_vblank_off()\n");
/...
Signed-off by: Woody Suwalski <terraluna977@gmail.com>
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c 2017-11-22
15:29:46.511674079 -0500
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c 2017-11-22
15:30:35.344559592 -0500
@@ -1869,7 +1869,7 @@ u32 vmw_get_vblank_counter(struct drm_de
*/
int vmw_enable_vblank(struct drm_device *dev, unsigned int pipe)
{
- return -ENOSYS;
+ return -EINVAL;
}
/**
next reply other threads:[~2017-11-22 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 21:05 Woody Suwalski [this message]
2017-12-13 21:25 ` Sinclair Yeh
2017-12-16 0:01 ` Woody Suwalski
2017-12-19 0:26 ` [PATCH v.2] " Woody Suwalski
2017-12-19 19:50 ` Sinclair Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com \
--to=terraluna977@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syeh@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome