From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: "Valdez, Jonathan" <j.valdez@ti.com>
Cc: dmitry.torokhov@gmail.com, kyle.manna@fuel7.com,
hns@goldelico.com, linux-input@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Input: tca8418-keypad: Incorrect values in a driver
Date: Mon, 20 Apr 2015 18:11:33 +0200 [thread overview]
Message-ID: <55352535.3030505@free-electrons.com> (raw)
In-Reply-To: <C63F243273B7A346BDF1A19060D79D6343D68D@DFLE10.ent.ti.com>
Hi Jonathan,
Thank you for reporting this issue!
On 03/30/2015 06:41 PM, Valdez, Jonathan wrote:
>
> Hello,
>
>
>
> I’ve been supporting the TCA8418 and have been pointed to your
> document by a few customers
> (http://lxr.free-electrons.com/source/drivers/input/keyboard/tca8418_keypad.c)
>
>
>
>
>
> The problem I am seeing is that you are writing a 1 to
> REG_DEBOUNCE_DIS1/2/3, which actually disables column debouncing. A 0
> enables it. This is easily fixed, but I wanted to bring this to your
> attention.
>
>
>
> Please see page 19 of the TCA8418 datasheet, where the registers are
> debounce_DIS(able) registers. A 0 keeps debouncing enabled. By default
> debounce is enabled.
>
>
>
> Best regards,
>
> Jonathan Valdez
>
> System Connectivity Applications
>
I'm not the maintainer of this code though, just showing the source code
on our LXR webste. I'm CCing the guys in charge.
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
parent reply other threads:[~2015-04-20 16:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <C63F243273B7A346BDF1A19060D79D6343D68D@DFLE10.ent.ti.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55352535.3030505@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hns@goldelico.com \
--cc=j.valdez@ti.com \
--cc=kyle.manna@fuel7.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome