* Re: Input: tca8418-keypad: Incorrect values in a driver
[not found] <C63F243273B7A346BDF1A19060D79D6343D68D@DFLE10.ent.ti.com>
@ 2015-04-20 16:11 ` Michael Opdenacker
0 siblings, 0 replies; only message in thread
From: Michael Opdenacker @ 2015-04-20 16:11 UTC (permalink / raw)
To: Valdez, Jonathan
Cc: dmitry.torokhov, kyle.manna, hns, linux-input, Linux Kernel Mailing List
Hi Jonathan,
Thank you for reporting this issue!
On 03/30/2015 06:41 PM, Valdez, Jonathan wrote:
>
> Hello,
>
>
>
> I’ve been supporting the TCA8418 and have been pointed to your
> document by a few customers
> (http://lxr.free-electrons.com/source/drivers/input/keyboard/tca8418_keypad.c)
>
>
>
>
>
> The problem I am seeing is that you are writing a 1 to
> REG_DEBOUNCE_DIS1/2/3, which actually disables column debouncing. A 0
> enables it. This is easily fixed, but I wanted to bring this to your
> attention.
>
>
>
> Please see page 19 of the TCA8418 datasheet, where the registers are
> debounce_DIS(able) registers. A 0 keeps debouncing enabled. By default
> debounce is enabled.
>
>
>
> Best regards,
>
> Jonathan Valdez
>
> System Connectivity Applications
>
I'm not the maintainer of this code though, just showing the source code
on our LXR webste. I'm CCing the guys in charge.
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
^ permalink raw reply [flat|nested] only message in thread