mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: mturquette@linaro.org, sboyd@codeaurora.org,
	s.nawrocki@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] clk: Show the clock rate when fail to set clock rate
Date: Mon, 27 Apr 2015 18:31:12 +0900	[thread overview]
Message-ID: <553E01E0.6060309@samsung.com> (raw)
In-Reply-To: <1430124809-21765-1-git-send-email-cw00.choi@samsung.com>

Dear all,

Please ignore this patch. I'll send v4 patch.

Thanks,
Chanwoo Choi

On 04/27/2015 05:53 PM, Chanwoo Choi wrote:
> This patch shows the current clock rate when fail to set the clock rate.
> because original error message show the error value instead of currrent clock
> rate.
> 
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes from v2:
> - Show the current clock rate when fail to set clock rate
> Changes from v1:
> - Add error value of clk_set_rate() with current clock rate
> 
>  drivers/clk/clk-conf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
> index 48a65b2..53d7449 100644
> --- a/drivers/clk/clk-conf.c
> +++ b/drivers/clk/clk-conf.c
> @@ -106,8 +106,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier)
>  
>  			rc = clk_set_rate(clk, rate);
>  			if (rc < 0)
> -				pr_err("clk: couldn't set %s clock rate: %d\n",
> -				       __clk_get_name(clk), rc);
> +				pr_err("clk: couldn't set %s clk rate to %ld\n",
> +				       __clk_get_name(clk), rate);
>  			clk_put(clk);
>  		}
>  		index++;
> 


      reply	other threads:[~2015-04-27  9:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  8:53 Chanwoo Choi
2015-04-27  9:31 ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553E01E0.6060309@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®