From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com
Subject: Re: [PATCH] KVM: x86: dump VMCS on invalid entry
Date: Sat, 02 May 2015 13:34:05 +0200 [thread overview]
Message-ID: <5544B62D.1010701@redhat.com> (raw)
In-Reply-To: <jpg618deb1e.fsf@redhat.com>
On 30/04/2015 20:17, Bandan Das wrote:
>> > Code and format roughly based on Xen's vmcs_dump_vcpu.
> Nice, but isn't it better to keep the output format and behavior the
> same for both dump_vmcb and dump_vmcs() ? why not pr_error ?
I didn't think of looking at dump_vmcb. :) I knew it existed, but I
didn't remember it's called in these exact circumstances.
The output seems a bit too verbose for pr_error... Maybe it's worth
changing dump_vmcb instead. Regarding the output format, some things
could be adjusted to match (especially the segments) but overall the
data is pretty different apart from the segments and a handful of other
fields.
Paolo
prev parent reply other threads:[~2015-05-02 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 10:57 Paolo Bonzini
2015-04-30 18:17 ` Bandan Das
2015-05-02 11:34 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5544B62D.1010701@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome