From: Jens Axboe <axboe@kernel.dk>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] block:Add proper error checking to the function, add_disk
Date: Sun, 17 May 2015 12:54:10 -0600 [thread overview]
Message-ID: <5558E3D2.30708@kernel.dk> (raw)
In-Reply-To: <1431862557-3325-1-git-send-email-xerofoify@gmail.com>
On 05/17/2015 05:35 AM, Nicholas Krause wrote:
> This adds proper error checking and handling to the function,
> add_disk by changing the return from void to a int. In addition
> we also change various WARN_ON statements in this function to
> proper if statements that now return a error code if there
> condition arises during this function's run. Finally we change
> the function prototype in genhd.h to return an int now rather
> then void.
Nick, I'm not going to keep looking at these. It's quite clear you are
out of your depth, hence the review to reward ratio (as a maintainer) is
just too high. This is the 3rd iteration of this patch in a few days,
all different, and no comments or version logs. So please stop fixing
FIXME patches for the block are, thanks.
This message does not require a reply.
--
Jens Axboe
parent reply other threads:[~2015-05-17 18:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1431862557-3325-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5558E3D2.30708@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome