* Re: [PATCH RESEND] block:Add proper error checking to the function, add_disk
[not found] <1431862557-3325-1-git-send-email-xerofoify@gmail.com>
@ 2015-05-17 18:54 ` Jens Axboe
0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2015-05-17 18:54 UTC (permalink / raw)
To: Nicholas Krause; +Cc: linux-kernel
On 05/17/2015 05:35 AM, Nicholas Krause wrote:
> This adds proper error checking and handling to the function,
> add_disk by changing the return from void to a int. In addition
> we also change various WARN_ON statements in this function to
> proper if statements that now return a error code if there
> condition arises during this function's run. Finally we change
> the function prototype in genhd.h to return an int now rather
> then void.
Nick, I'm not going to keep looking at these. It's quite clear you are
out of your depth, hence the review to reward ratio (as a maintainer) is
just too high. This is the 3rd iteration of this patch in a few days,
all different, and no comments or version logs. So please stop fixing
FIXME patches for the block are, thanks.
This message does not require a reply.
--
Jens Axboe
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-17 18:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1431862557-3325-1-git-send-email-xerofoify@gmail.com>
2015-05-17 18:54 ` [PATCH RESEND] block:Add proper error checking to the function, add_disk Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome