From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Johan Hovold <johan@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] firmware: qcom: uefisecapp: add support for R/O UEFI vars
Date: Mon, 23 Jun 2025 16:52:58 +0200 [thread overview]
Message-ID: <55624c7d-0192-43ec-b367-f33c96866a2a@oss.qualcomm.com> (raw)
In-Reply-To: <aFlqGMWwx8ID_SaN@hovoldconsulting.com>
On 6/23/25 4:52 PM, Johan Hovold wrote:
> On Mon, Jun 23, 2025 at 04:49:22PM +0200, Konrad Dybcio wrote:
>> On 6/23/25 4:45 PM, Johan Hovold wrote:
>
>>> It looks like the efivars implementation does not support read-only
>>> efivars and this will lead to NULL pointer dereferences whenever you try
>>> to write a variable.
>>
>> There's efivar_supports_writes() that is used to set the EFIVAR_OPS_RDONLY
>> flag which then sets SB_RDONLY on all efivarfs superblocks
>
> Yep, but it doesn't help when attempting to store the RTC offset from
> the kernel (since that does not use efivarfs).
You're right, that hole needs patching
Konrad
next prev parent reply other threads:[~2025-06-23 14:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 19:56 [PATCH v2 0/4] firmware: qcom: enable UEFI variables on Lenovo Yoga C630 Dmitry Baryshkov
2025-06-21 19:56 ` [PATCH v2 1/4] firmware: qcom: scm: allow specifying quirks for QSEECOM implementations Dmitry Baryshkov
2025-06-23 10:33 ` Konrad Dybcio
2025-06-21 19:56 ` [PATCH v2 2/4] firmware: qcom: uefisecapp: add support for R/O UEFI vars Dmitry Baryshkov
2025-06-23 14:45 ` Johan Hovold
2025-06-23 14:49 ` Konrad Dybcio
2025-06-23 14:52 ` Johan Hovold
2025-06-23 14:52 ` Konrad Dybcio [this message]
2025-06-23 14:50 ` Johan Hovold
2025-06-24 1:13 ` Dmitry Baryshkov
2025-06-26 9:42 ` Johan Hovold
2025-06-26 11:15 ` Dmitry Baryshkov
2025-06-26 13:13 ` Johan Hovold
2025-06-26 13:49 ` Konrad Dybcio
2025-06-26 14:07 ` Johan Hovold
2025-06-26 23:09 ` Dmitry Baryshkov
2025-06-27 12:16 ` Johan Hovold
2025-06-21 19:56 ` [PATCH v2 3/4] firmware: qcom: enable QSEECOM on Lenovo Yoga C630 Dmitry Baryshkov
2025-06-23 10:36 ` Konrad Dybcio
2025-06-21 19:56 ` [PATCH v2 4/4] arm64: dts: qcom: sdm850-lenovo-yoga-c630: fix RTC offset info Dmitry Baryshkov
2025-06-23 10:36 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55624c7d-0192-43ec-b367-f33c96866a2a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®