mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Prarit Bhargava <prarit@redhat.com>,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Radivoje Jovanovic <radivoje.jovanovic@intel.com>,
	Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>,
	Mathias Krause <minipli@googlemail.com>,
	Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
Subject: Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check
Date: Thu, 10 Dec 2015 00:38:27 +0100	[thread overview]
Message-ID: <5563622.j8xTDST9Ds@vostro.rjw.lan> (raw)
In-Reply-To: <20151209085355.6442a508@icelake>

On Wednesday, December 09, 2015 08:53:55 AM Jacob Pan wrote:
> On Wed,  9 Dec 2015 08:31:12 -0500
> Prarit Bhargava <prarit@redhat.com> wrote:
> 
> > Intel RAPL initialized on several systems where the BIOS lock bit (msr
> > 0x610, bit 63) was set.  This occured because the return value of
> > rapl_read_data_raw() was being checked, rather than the value of the
> > variable passed in, locked.
> > 
> > This patch properly implments the rapl_read_data_raw() call to check
> > the variable locked, and now the Intel RAPL driver outputs the
> > warning:
> > 
> > 	intel_rapl: RAPL package 0 domain package locked by BIOS
> > 
> > and does not initialize for the package.
> > 
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Radivoje Jovanovic <radivoje.jovanovic@intel.com>
> > Cc: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
> > Cc: Mathias Krause <minipli@googlemail.com>
> > Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> > Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> > 
> > [v2]: fix brackets
> 
> Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

OK, I've put it into my bleeding-edge branch as 4.5 candidate, but do we
want it in "stable" and therefore should it be pushed for 4.4?

Thanks,
Rafael


  reply	other threads:[~2015-12-09 23:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 13:31 Prarit Bhargava
2015-12-09 16:53 ` Jacob Pan
2015-12-09 23:38   ` Rafael J. Wysocki [this message]
2015-12-09 23:31     ` Jacob Pan
2015-12-10  0:52       ` Rafael J. Wysocki
2015-12-10 11:04         ` Prarit Bhargava
2015-12-11 16:39         ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5563622.j8xTDST9Ds@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=ajay.thomas.david.rajamanickam@intel.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minipli@googlemail.com \
    --cc=prarit@redhat.com \
    --cc=radivoje.jovanovic@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=s.ikarashi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®