From: "Christian König" <deathsimple@vodafone.de>
To: "Alexander Kuleshov" <kuleshovmail@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Christian König" <christian.koenig@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Jammy Zhou" <Jammy.Zhou@amd.com>, "monk.liu" <monk.liu@amd.com>,
"Marek Olšák" <marek.olsak@amd.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu/drm/amdgpu: Fix build when CONFIG_DEBUG_FS is not set
Date: Mon, 29 Jun 2015 09:52:38 +0200 [thread overview]
Message-ID: <5590F946.8040507@vodafone.de> (raw)
In-Reply-To: <1435389365-1594-1-git-send-email-kuleshovmail@gmail.com>
On 27.06.2015 09:16, Alexander Kuleshov wrote:
> If the CONFIG_DEBUG_FS is not selected, compilation of the
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c provides two warnings that
> amdgpu_debugfs_regs_init and amdgpu_debugfs_regs_cleanup are used but
> never defined. And as result:
>
> ERROR: "amdgpu_debugfs_regs_cleanup" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: "amdgpu_debugfs_regs_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ^
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..6896798 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2000,5 +2000,10 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
> void amdgpu_debugfs_cleanup(struct drm_minor *minor)
> {
> }
> +#else
> +static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev)
> +{
> + return 0;
> +}
> +static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev) { }
> #endif
> --
> 2.4.4.410.gc71d752
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-06-29 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 7:16 Alexander Kuleshov
2015-06-29 7:52 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5590F946.8040507@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=Jammy.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.olsak@amd.com \
--cc=monk.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®