* [PATCH] gpu/drm/amdgpu: Fix build when CONFIG_DEBUG_FS is not set
@ 2015-06-27 7:16 Alexander Kuleshov
2015-06-29 7:52 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kuleshov @ 2015-06-27 7:16 UTC (permalink / raw)
To: David Airlie, Christian König, Alex Deucher, Jammy Zhou,
monk.liu, Marek Olšák
Cc: dri-devel, linux-kernel, Alexander Kuleshov
If the CONFIG_DEBUG_FS is not selected, compilation of the
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c provides two warnings that
amdgpu_debugfs_regs_init and amdgpu_debugfs_regs_cleanup are used but
never defined. And as result:
ERROR: "amdgpu_debugfs_regs_cleanup" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "amdgpu_debugfs_regs_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
^
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index fec487d..6896798 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2000,5 +2000,10 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
void amdgpu_debugfs_cleanup(struct drm_minor *minor)
{
}
+#else
+static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev)
+{
+ return 0;
+}
+static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev) { }
#endif
--
2.4.4.410.gc71d752
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpu/drm/amdgpu: Fix build when CONFIG_DEBUG_FS is not set
2015-06-27 7:16 [PATCH] gpu/drm/amdgpu: Fix build when CONFIG_DEBUG_FS is not set Alexander Kuleshov
@ 2015-06-29 7:52 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2015-06-29 7:52 UTC (permalink / raw)
To: Alexander Kuleshov, David Airlie, Christian König,
Alex Deucher, Jammy Zhou, monk.liu, Marek Olšák
Cc: linux-kernel, dri-devel
On 27.06.2015 09:16, Alexander Kuleshov wrote:
> If the CONFIG_DEBUG_FS is not selected, compilation of the
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c provides two warnings that
> amdgpu_debugfs_regs_init and amdgpu_debugfs_regs_cleanup are used but
> never defined. And as result:
>
> ERROR: "amdgpu_debugfs_regs_cleanup" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: "amdgpu_debugfs_regs_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ^
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..6896798 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2000,5 +2000,10 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
> void amdgpu_debugfs_cleanup(struct drm_minor *minor)
> {
> }
> +#else
> +static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev)
> +{
> + return 0;
> +}
> +static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev) { }
> #endif
> --
> 2.4.4.410.gc71d752
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-29 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-27 7:16 [PATCH] gpu/drm/amdgpu: Fix build when CONFIG_DEBUG_FS is not set Alexander Kuleshov
2015-06-29 7:52 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®