From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Kalle Valo <kvalo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH wireless-next 2/2] ath: dfs_pattern_detector: Use flex array to simplify code
Date: Mon, 25 Sep 2023 17:45:10 -0700 [thread overview]
Message-ID: <5591d8a4-24be-4288-88df-29fd5a11ac66@quicinc.com> (raw)
In-Reply-To: <1920cc38db2e570633e13b37d50852f3202a7270.1695538105.git.christophe.jaillet@wanadoo.fr>
On 9/23/2023 11:57 PM, Christophe JAILLET wrote:
> At the time of the writing, the value of 'num_radar_types' is 7 or 9. So
> on a 64 bits system, only 56 or 72 bytes are allocated for the
> 'detectors' array.
>
> Turn it into a flex array, in order to simplify memory management and save
> an indirection when the array is used.
>
> Doing so, cd->detectors can't be NULL, and channel_detector_exit() can be
> simplified as well.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
next prev parent reply other threads:[~2023-09-26 0:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 6:57 [PATCH wireless 1/2] ath: dfs_pattern_detector: Fix a memory initialization issue Christophe JAILLET
2023-09-24 6:57 ` [PATCH wireless-next 2/2] ath: dfs_pattern_detector: Use flex array to simplify code Christophe JAILLET
2023-09-26 0:45 ` Jeff Johnson [this message]
2023-09-25 18:46 ` [PATCH wireless 1/2] ath: dfs_pattern_detector: Fix a memory initialization issue Jeff Johnson
2023-09-25 20:54 ` Christophe JAILLET
2023-09-26 0:27 ` Jeff Johnson
2023-09-26 0:44 ` Jeff Johnson
2023-10-02 16:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5591d8a4-24be-4288-88df-29fd5a11ac66@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®