From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: <kernel-janitors@vger.kernel.org>, <kvalo@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<quic_kvalo@quicinc.com>
Subject: Re: [PATCH wireless 1/2] ath: dfs_pattern_detector: Fix a memory initialization issue
Date: Mon, 25 Sep 2023 17:27:18 -0700 [thread overview]
Message-ID: <ed6a9fe3-9197-4ffd-9fd4-c1a959b7fdc9@quicinc.com> (raw)
In-Reply-To: <b3be8653-ea3f-bc3a-c38e-e3ec290695ea@wanadoo.fr>
On 9/25/2023 1:54 PM, Christophe JAILLET wrote:
> Le 25/09/2023 à 20:46, Jeff Johnson a écrit :
>> On 9/23/2023 11:57 PM, Christophe JAILLET wrote:
>>> - cd->detectors = kmalloc_array(dpd->num_radar_types,
>>> + cd->detectors = kcalloc(dpd->num_radar_types,
>>> sizeof(*cd->detectors), GFP_ATOMIC);
>>
>> nit: align descendant on (
>
> Agreed, but as the code is removed in patch 2/2, I thought that having a
> smaller diff was a better option.
>
> Let me know if I should resend the serie.
nevermind, don't bother
next prev parent reply other threads:[~2023-09-26 0:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 6:57 Christophe JAILLET
2023-09-24 6:57 ` [PATCH wireless-next 2/2] ath: dfs_pattern_detector: Use flex array to simplify code Christophe JAILLET
2023-09-26 0:45 ` Jeff Johnson
2023-09-25 18:46 ` [PATCH wireless 1/2] ath: dfs_pattern_detector: Fix a memory initialization issue Jeff Johnson
2023-09-25 20:54 ` Christophe JAILLET
2023-09-26 0:27 ` Jeff Johnson [this message]
2023-09-26 0:44 ` Jeff Johnson
2023-10-02 16:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6a9fe3-9197-4ffd-9fd4-c1a959b7fdc9@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_kvalo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®