From: Yunfeng Ye <yeyunfeng@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
"Shiyuan Hu" <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3] tools/bootconfig: fix resource leak in apply_xbc()
Date: Fri, 8 May 2020 19:18:39 +0800 [thread overview]
Message-ID: <559edb00-a03b-747e-8ba7-1f16285deefb@huawei.com> (raw)
In-Reply-To: <5e2c3348-f346-e3f2-9c7c-5c4135f9b38c@web.de>
On 2020/5/8 19:03, Markus Elfring wrote:
> …
>> +++ b/tools/bootconfig/main.c
>> @@ -314,31 +314,35 @@ int apply_xbc(const char *path, const char *xbc_path)
> …
>> +free_data:
>> free(data);
> …
>
> Would any software users prefer to omit the memory release for
> a quicker program termination?
>
> Can the commit message become clearer about the explanation for
> the importance of the proposed change?
>
ok, thanks. this change can fix the warning of tools.
> Regards,
> Markus
>
>
next prev parent reply other threads:[~2020-05-08 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 10:52 Yunfeng Ye
2020-05-08 11:03 ` Markus Elfring
2020-05-08 11:18 ` Yunfeng Ye [this message]
2020-05-08 11:30 ` [v3] " Markus Elfring
2020-05-08 11:42 ` Yunfeng Ye
2020-05-08 13:00 ` Steven Rostedt
2020-05-08 13:06 ` Markus Elfring
2020-05-08 14:45 ` Dan Carpenter
2020-05-08 15:14 ` Steven Rostedt
2020-05-08 16:42 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559edb00-a03b-747e-8ba7-1f16285deefb@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®