From: Markus Elfring <Markus.Elfring@web.de>
To: Steven Rostedt <rostedt@goodmis.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Yunfeng Ye <yeyunfeng@huawei.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [v3] tools/bootconfig: fix resource leak in apply_xbc()
Date: Fri, 8 May 2020 18:42:05 +0200 [thread overview]
Message-ID: <dbfae758-c516-dca1-5511-9618510e49e8@web.de> (raw)
In-Reply-To: <20200508111449.575d176c@gandalf.local.home>
>> There was actually a bug in v2. It exits with a non-zero instead of
>> zero on success so it will mess up people's scripts.
>
> Thanks, I just fixed it. And because of the distraction of Markus's
> bikesheding, it was missed :-(
I am curious how the software development attention will evolve further.
tools/bootconfig: Fix apply_xbc() to return zero on success
https://lore.kernel.org/lkml/20200508111349.3b599bde@gandalf.local.home/
https://lore.kernel.org/patchwork/patch/1239092/
https://lkml.org/lkml/2020/5/8/1342
Will additional change possibilities be taken into account?
Regards,
Markus
prev parent reply other threads:[~2020-05-08 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 10:52 [PATCH v3] " Yunfeng Ye
2020-05-08 11:03 ` Markus Elfring
2020-05-08 11:18 ` Yunfeng Ye
2020-05-08 11:30 ` [v3] " Markus Elfring
2020-05-08 11:42 ` Yunfeng Ye
2020-05-08 13:00 ` Steven Rostedt
2020-05-08 13:06 ` Markus Elfring
2020-05-08 14:45 ` Dan Carpenter
2020-05-08 15:14 ` Steven Rostedt
2020-05-08 16:42 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbfae758-c516-dca1-5511-9618510e49e8@web.de \
--to=markus.elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®