* Re: [PATCH] net:bcmgent:Return the variable ret rather then zero for the function bcmgenet_power_down
[not found] <1437075256-21395-1-git-send-email-xerofoify@gmail.com>
@ 2015-07-16 19:35 ` Florian Fainelli
0 siblings, 0 replies; only message in thread
From: Florian Fainelli @ 2015-07-16 19:35 UTC (permalink / raw)
To: Nicholas Krause; +Cc: netdev, linux-kernel
On 16/07/15 12:34, Nicholas Krause wrote:
> This makes the function bcmgenet_power_down return the variable ret
> rather then zero in order to make this function be able to signal its
> caller with a error code when a failure occurs internally rather then
> always appearing to run successfully to its caller.
Still not quite the right subject (missing spaces, typos), copy/paste this:
net: bcmgenet: Return the variable ret rather then zero for the function
bcmgenet_power_down
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 64c1e9d..129e5b5 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -877,7 +877,7 @@ static int bcmgenet_power_down(struct bcmgenet_priv *priv,
> break;
> }
>
> - return 0;
> + return ret;
> }
>
> static void bcmgenet_power_up(struct bcmgenet_priv *priv,
>
--
Florian
^ permalink raw reply [flat|nested] only message in thread