From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <rafal@milecki.pl>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB
Date: Mon, 14 Dec 2020 09:32:16 -0800 [thread overview]
Message-ID: <55a37742-1f4e-3697-e0e2-e42d67d75e07@gmail.com> (raw)
In-Reply-To: <18ebb7ab-2a45-f9fb-a094-0e63d44eadad@milecki.pl>
On 12/14/20 4:24 AM, Rafał Miłecki wrote:
> On 11.12.2020 23:08, Florian Fainelli wrote:
>> On 12/11/20 1:59 PM, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138).
>>> It's needed to power on and off SoC blocks like PCIe, SATA, USB.
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> I will do a more thorough review tonight, however do you mind moving the
>> driver under drives/soc/bcm/bcm63xx? The first SoC that had PMB was
>> 63138 and that one is DSL.
>
> I now realized that bcm63xx's:
> * Kconfig is wrapper in: if SOC_BCM63XX
> * Makefile is conditional: obj-$(CONFIG_SOC_BCM63XX)
>
> So it means I've to either:
> 1. Refactor bcm63xx structure
> 2. Make SOC_BCM63XX selectable on ARCH_BCM4908 and select it
>
> I'm not sure if any of above is a really good idea. Any further thought,
> ideas?
Well, I was thinking about thing along those lines below, it's really
about putting drivers that belong to the same SoC family in the same
basket for easier maintenance while submitting patches/pull requests
from my side.
diff --git a/drivers/soc/bcm/Makefile b/drivers/soc/bcm/Makefile
index 7bc90e0bd773..0f0efa28d92b 100644
--- a/drivers/soc/bcm/Makefile
+++ b/drivers/soc/bcm/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
obj-$(CONFIG_BCM2835_POWER) += bcm2835-power.o
obj-$(CONFIG_RASPBERRYPI_POWER) += raspberrypi-power.o
-obj-$(CONFIG_SOC_BCM63XX) += bcm63xx/
+obj-y += bcm63xx/
obj-$(CONFIG_SOC_BRCMSTB) += brcmstb/
diff --git a/drivers/soc/bcm/bcm63xx/Kconfig
b/drivers/soc/bcm/bcm63xx/Kconfig
index 16f648a6c70a..76fb61e7377e 100644
--- a/drivers/soc/bcm/bcm63xx/Kconfig
+++ b/drivers/soc/bcm/bcm63xx/Kconfig
@@ -10,3 +10,8 @@ config BCM63XX_POWER
BCM6318, BCM6328, BCM6362 and BCM63268 SoCs.
endif # SOC_BCM63XX
+
+config BCM_PMB_POWER
+ tristate "Broadcom PMB bus power domain driver"
+ depends on BMIPS_GENERIC || ARCH_BCM4908 || COMPILE_TEST
+ default ARCH_BCM4908
--
Florian
next prev parent reply other threads:[~2020-12-14 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 21:59 [PATCH 0/2] Broadcom's PMB (Power Management Bus) support Rafał Miłecki
2020-12-11 21:59 ` [PATCH 1/2] dt-bindings: power: document Broadcom's PMB binding Rafał Miłecki
2020-12-11 21:59 ` [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB Rafał Miłecki
2020-12-11 22:02 ` Rafał Miłecki
2020-12-11 22:08 ` Florian Fainelli
2020-12-11 22:10 ` Rafał Miłecki
2020-12-14 12:24 ` Rafał Miłecki
2020-12-14 17:32 ` Florian Fainelli [this message]
2020-12-14 17:34 ` Rafał Miłecki
2020-12-12 3:26 ` Florian Fainelli
2020-12-14 8:00 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a37742-1f4e-3697-e0e2-e42d67d75e07@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rafal@milecki.pl \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome