From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Patrice Chotard <patrice.chotard@foss.st.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: stih407-usb: Use syscon_regmap_lookup_by_phandle_args
Date: Wed, 12 Feb 2025 21:30:39 +0100 [thread overview]
Message-ID: <55aed776-ebee-4b0a-a6e0-17732fdd5191@linaro.org> (raw)
In-Reply-To: <20250111185407.183855-1-krzysztof.kozlowski@linaro.org>
On 11/01/2025 19:54, Krzysztof Kozlowski wrote:
> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
> syscon_regmap_lookup_by_phandle() combined with getting the syscon
> argument. Except simpler code this annotates within one line that given
> phandle has arguments, so grepping for code would be easier.
>
> There is also no real benefit in printing errors on missing syscon
> argument, because this is done just too late: runtime check on
> static/build-time data. Dtschema and Devicetree bindings offer the
> static/build-time check for this already.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/phy/st/phy-stih407-usb.c | 24 +++++++-----------------
> 1 file changed, 7 insertions(+), 17 deletions(-)
Vinod, was this patch lost?
There is review and patch should still apply. Let me know if you need
resend.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-12 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 18:54 Krzysztof Kozlowski
2025-01-13 8:27 ` Patrice CHOTARD
2025-02-12 20:30 ` Krzysztof Kozlowski [this message]
2025-02-13 18:17 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55aed776-ebee-4b0a-a6e0-17732fdd5191@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=patrice.chotard@foss.st.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®