From: Vinod Koul <vkoul@kernel.org>
To: Patrice Chotard <patrice.chotard@foss.st.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] phy: stih407-usb: Use syscon_regmap_lookup_by_phandle_args
Date: Thu, 13 Feb 2025 23:47:00 +0530 [thread overview]
Message-ID: <173947062030.294083.9746743441329264653.b4-ty@kernel.org> (raw)
In-Reply-To: <20250111185407.183855-1-krzysztof.kozlowski@linaro.org>
On Sat, 11 Jan 2025 19:54:07 +0100, Krzysztof Kozlowski wrote:
> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
> syscon_regmap_lookup_by_phandle() combined with getting the syscon
> argument. Except simpler code this annotates within one line that given
> phandle has arguments, so grepping for code would be easier.
>
> There is also no real benefit in printing errors on missing syscon
> argument, because this is done just too late: runtime check on
> static/build-time data. Dtschema and Devicetree bindings offer the
> static/build-time check for this already.
>
> [...]
Applied, thanks!
[1/1] phy: stih407-usb: Use syscon_regmap_lookup_by_phandle_args
commit: 13c1eb1b4bd169f820188c62acaa1f96677284b1
Best regards,
--
~Vinod
prev parent reply other threads:[~2025-02-13 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 18:54 Krzysztof Kozlowski
2025-01-13 8:27 ` Patrice CHOTARD
2025-02-12 20:30 ` Krzysztof Kozlowski
2025-02-13 18:17 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173947062030.294083.9746743441329264653.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=patrice.chotard@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®