From: "Arnd Bergmann" <arnd@arndb.de>
To: "Michal Simek" <michal.simek@amd.com>,
"Tanmay Shah" <tanmays@amd.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>
Cc: soc@kernel.org, "Tanmay Shah" <tanmay.shah@xilinx.com>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Ben Levinsky" <ben.levinsky@amd.com>,
"Ronak Jain" <ronak.jain@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: zynqmp: fix declarations for gcc-13
Date: Wed, 18 Jan 2023 08:31:55 +0100 [thread overview]
Message-ID: <55cb1658-488e-4ed3-b5f9-5d97c0041dd9@app.fastmail.com> (raw)
In-Reply-To: <40bf8f6c-c2a1-88cd-163a-256d8d0bb029@amd.com>
On Wed, Jan 18, 2023, at 08:29, Michal Simek wrote:
> On 1/17/23 21:03, Arnd Bergmann wrote:
>>
>> On Tue, Jan 17, 2023, at 20:53, Tanmay Shah wrote:
>>> This looks good to me. Thanks for fixing this.
>>>
>>> Something must have gone wrong when I ran sparse check on this patch.
>>
>> I don't think any of our previous tooling caught this, only gcc-13
>> changed some of the behavior around enums.
>>
>>> Just one question, does this patch need "fixes:" tag?
>>
>> Probably a good idea:
>>
>> Fixes: a5e56980cfb7 ("firmware: xilinx: Add RPU configuration APIs")
>>
>> I can apply this directly to the soc fixes branch if you like
>> and add that line.
>
> I have other patches in my soc branch to send you too.
> Around next week I will be sending PR for it.
> I can include this one too but up2you.
Since this is required for building with the latest compiler
I think we want this in 6.2 and backported to stable kernels
quickly. I'm about to send a fixes pull request for 6.2, so I'll
just include it here.
Arnd
next prev parent reply other threads:[~2023-01-18 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230117164133.1245749-1-arnd@kernel.org>
2023-01-17 19:53 ` Tanmay Shah
2023-01-17 20:03 ` Arnd Bergmann
2023-01-17 20:14 ` Tanmay Shah
2023-01-18 7:29 ` Michal Simek
2023-01-18 7:31 ` Arnd Bergmann [this message]
2023-01-18 7:38 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55cb1658-488e-4ed3-b5f9-5d97c0041dd9@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=ronak.jain@xilinx.com \
--cc=soc@kernel.org \
--cc=tanmay.shah@xilinx.com \
--cc=tanmays@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®