mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Tanmay Shah" <tanmays@amd.com>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Michal Simek" <michal.simek@xilinx.com>
Cc: soc@kernel.org, "Tanmay Shah" <tanmay.shah@xilinx.com>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Ben Levinsky" <ben.levinsky@amd.com>,
	"Ronak Jain" <ronak.jain@xilinx.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: zynqmp: fix declarations for gcc-13
Date: Tue, 17 Jan 2023 21:03:26 +0100	[thread overview]
Message-ID: <eec4d2fd-f305-452a-a47f-83203da494df@app.fastmail.com> (raw)
In-Reply-To: <d6166b85-01df-405b-3112-d9bde16b6bd9@amd.com>

On Tue, Jan 17, 2023, at 20:53, Tanmay Shah wrote:
> This looks good to me. Thanks for fixing this.
>
> Something must have gone wrong when I ran sparse check on this patch.

I don't think any of our previous tooling caught this, only gcc-13
changed some of the behavior around enums.

> Just one question, does this patch need "fixes:" tag?

Probably a good idea:

Fixes: a5e56980cfb7 ("firmware: xilinx: Add RPU configuration APIs")

I can apply this directly to the soc fixes branch if you like
and add that line.

     Arnd

  reply	other threads:[~2023-01-17 21:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230117164133.1245749-1-arnd@kernel.org>
2023-01-17 19:53 ` Tanmay Shah
2023-01-17 20:03   ` Arnd Bergmann [this message]
2023-01-17 20:14     ` Tanmay Shah
2023-01-18  7:29     ` Michal Simek
2023-01-18  7:31       ` Arnd Bergmann
2023-01-18  7:38         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eec4d2fd-f305-452a-a47f-83203da494df@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=ben.levinsky@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=michal.simek@xilinx.com \
    --cc=ronak.jain@xilinx.com \
    --cc=soc@kernel.org \
    --cc=tanmay.shah@xilinx.com \
    --cc=tanmays@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®