mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Richter <Simon.Richter@hogyros.de>
To: "Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Constantinos Chalkias" <cch@e-psn.eu>,
	"Bata Roland Krisztián" <batarolandkrisztian@gmail.com>
Cc: intel-xe@lists.freedesktop.org, matthew.brost@intel.com,
	thomas.hellstrom@linux.intel.com, airlied@gmail.com,
	simona@ffwll.ch, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/xe/hwmon: refresh Battlemage thermal telemetry under force-wake
Date: Thu, 15 Oct 2026 11:29:37 +0900	[thread overview]
Message-ID: <55cba965-208a-44cd-a644-e664410af8a5@hogyros.de> (raw)
In-Reply-To: <as_iOd6A_Yncj8Gt@intel.com>

Hi,

On 10/15/26 5:12 AM, Rodrigo Vivi wrote:

> If the consensus is that we need this forcewake, let's do it.
It feels like we haven't really understood the problem yet, we just know 
something that appears to work.

If I run

     while true; do sleep 5 >forcewake_all; sleep 5; done & watch sensors

then the temperature sensors *do* update, but several of the VRAM 
channels take over a minute, so the long forcewake does not solve the 
problem. If shorter ones do, then I'd really like to understand why; my 
theory is that it's not the forcewake itself that does the job, but the 
fact that it's toggling, and possibly generating some events in some 
microcontroller. It may be sufficient to send some no-op commands 
instead of playing with the power rails.

Starting the loop above with pretty much everything at a nice toasty 
equilibrium temperature of 82 degrees (which is way too much IMO for a 
card that has no client connected and is just displaying a console 
login), the fans immediately come on, and apparently every ten seconds 
one of the VRAM channels updates to a lower temperature, so one 
forcewake event pretty much exactly corresponds to one sensor update.

That would explain why the patch works -- it generates the same number 
of forcewake events as sensor reads, and the delay makes sure they are 
registered as separate events. However, there is no correspondence 
between the event and the sensor, so if I do my normal telemetry 
recording (every sensor once every ten seconds) I can still get data 
that is ten seconds old, and I also wake up the GPU once every ten 
seconds even if there is nothing to do.

That is an improvement over the status quo, but my concern is that it 
will push us over into "good enough" territory where the actual problem 
is never addressed.

    Simon

  parent reply	other threads:[~2026-10-15  2:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 10:42 Constantinos Chalkias
2026-10-14 20:12 ` Rodrigo Vivi
2026-10-15  0:37   ` Constantinos Chalkias
2026-10-15  2:29   ` Simon Richter [this message]
2026-10-15 12:47     ` Rodrigo Vivi
2026-10-15 13:09       ` Simon Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55cba965-208a-44cd-a644-e664410af8a5@hogyros.de \
    --to=simon.richter@hogyros.de \
    --cc=airlied@gmail.com \
    --cc=batarolandkrisztian@gmail.com \
    --cc=cch@e-psn.eu \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®