From: Taniya Das <taniya.das@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Subject: Re: [PATCH] clk: qcom: rpmh: Fix LNBBCLK3 divider for X1E80100
Date: Wed, 18 Feb 2026 22:46:00 +0530 [thread overview]
Message-ID: <55dafd36-8b6c-49e1-9579-62e6d97c1692@oss.qualcomm.com> (raw)
In-Reply-To: <20260211-hamoa_ufs_clk8-v1-1-b537f54e9353@oss.qualcomm.com>
On 2/11/2026 11:52 PM, Taniya Das wrote:
> DEFINE_CLK_RPMH_VRM(clk5, _a1, "clka5", 1);
> +DEFINE_CLK_RPMH_VRM(clk8, _a1, "clka8", 1);
>
> DEFINE_CLK_RPMH_VRM(clk3, _a2, "clka3", 2);
> DEFINE_CLK_RPMH_VRM(clk4, _a2, "clka4", 2);
> @@ -840,8 +841,8 @@ static struct clk_hw *x1e80100_rpmh_clocks[] = {
> [RPMH_LN_BB_CLK1_A] = &clk_rpmh_clk6_a2_ao.hw,
> [RPMH_LN_BB_CLK2] = &clk_rpmh_clk7_a2.hw,
> [RPMH_LN_BB_CLK2_A] = &clk_rpmh_clk7_a2_ao.hw,
> - [RPMH_LN_BB_CLK3] = &clk_rpmh_clk8_a2.hw,
> - [RPMH_LN_BB_CLK3_A] = &clk_rpmh_clk8_a2_ao.hw,
> + [RPMH_LN_BB_CLK3] = &clk_rpmh_clk8_a1.hw,
> + [RPMH_LN_BB_CLK3_A] = &clk_rpmh_clk8_a1_ao.hw,
> [RPMH_RF_CLK3] = &clk_rpmh_clk3_a2.hw,
> [RPMH_RF_CLK3_A] = &clk_rpmh_clk3_a2_ao.hw,
> [RPMH_RF_CLK4] = &clk_rpmh_clk4_a2.hw,
Bjorn, request is to drop picking this change. This fix was identified
as part of downstream validations, but what I realised late was the DTSI
of hamoa upstream and downstream had a difference in the way the
xo_board frequency was defined. Upstream DTSI xo_board freq = 76.8MHz
and downstream DTSI xo_board = 38.4MHz.
The xo_board frequency seems incorrect(upstream) when I mapped it to HW
design and needs a much more involved change in hamoa DTSI as well as
the RPMH clocks.
I will send out a v2 patch later which should take care to fix.
--
Thanks,
Taniya Das
prev parent reply other threads:[~2026-02-18 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 18:22 Taniya Das
2026-02-11 19:35 ` Dmitry Baryshkov
2026-02-12 10:38 ` Konrad Dybcio
2026-02-12 10:39 ` Konrad Dybcio
2026-02-18 17:16 ` Taniya Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55dafd36-8b6c-49e1-9579-62e6d97c1692@oss.qualcomm.com \
--to=taniya.das@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_rjendra@quicinc.com \
--cc=sboyd@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®