* [PATCH] drm/imagination: Free pvr_vm_gpuva after unlink
@ 2024-08-28 13:13 Matt Coster
2024-08-30 14:03 ` Frank Binns
2024-08-30 15:07 ` [PATCH RESEND] " Matt Coster
0 siblings, 2 replies; 4+ messages in thread
From: Matt Coster @ 2024-08-28 13:13 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, dri-devel, linux-kernel
Cc: Frank Binns
[-- Attachment #1.1: Type: text/plain, Size: 1330 bytes --]
This caused a measurable memory leak. Although the individual
allocations are small, the leaks occurs in a high-usage codepath
(remapping or unmapping device memory) so they add up quickly.
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/imagination/pvr_vm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/imagination/pvr_vm.c
b/drivers/gpu/drm/imagination/pvr_vm.c
index e59517ba039e..97c0f772ed65 100644
--- a/drivers/gpu/drm/imagination/pvr_vm.c
+++ b/drivers/gpu/drm/imagination/pvr_vm.c
@@ -114,6 +114,8 @@ struct pvr_vm_gpuva {
struct drm_gpuva base;
};
+#define to_pvr_vm_gpuva(va) container_of_const(va, struct
pvr_vm_gpuva, base)
+
enum pvr_vm_bind_type {
PVR_VM_BIND_TYPE_MAP,
PVR_VM_BIND_TYPE_UNMAP,
@@ -386,6 +388,7 @@ pvr_vm_gpuva_unmap(struct drm_gpuva_op *op, void
*op_ctx)
drm_gpuva_unmap(&op->unmap);
drm_gpuva_unlink(op->unmap.va);
+ kfree(to_pvr_vm_gpuva(op->unmap.va));
return 0;
}
@@ -433,6 +436,7 @@ pvr_vm_gpuva_remap(struct drm_gpuva_op *op, void
*op_ctx)
}
drm_gpuva_unlink(op->remap.unmap->va);
+ kfree(to_pvr_vm_gpuva(op->remap.unmap->va));
return 0;
}
--
2.46.0
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/imagination: Free pvr_vm_gpuva after unlink
2024-08-28 13:13 [PATCH] drm/imagination: Free pvr_vm_gpuva after unlink Matt Coster
@ 2024-08-30 14:03 ` Frank Binns
2024-08-30 15:07 ` [PATCH RESEND] " Matt Coster
1 sibling, 0 replies; 4+ messages in thread
From: Frank Binns @ 2024-08-30 14:03 UTC (permalink / raw)
To: tzimmermann, Matt Coster, dri-devel, airlied, linux-kernel,
maarten.lankhorst, daniel, mripard
On Wed, 2024-08-28 at 13:13 +0000, Matt Coster wrote:
> This caused a measurable memory leak. Although the individual
> allocations are small, the leaks occurs in a high-usage codepath
> (remapping or unmapping device memory) so they add up quickly.
>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/imagination/pvr_vm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_vm.c
> b/drivers/gpu/drm/imagination/pvr_vm.c
> index e59517ba039e..97c0f772ed65 100644
> --- a/drivers/gpu/drm/imagination/pvr_vm.c
> +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> @@ -114,6 +114,8 @@ struct pvr_vm_gpuva {
> struct drm_gpuva base;
> };
> +#define to_pvr_vm_gpuva(va) container_of_const(va, struct
> pvr_vm_gpuva, base)
> +
> enum pvr_vm_bind_type {
> PVR_VM_BIND_TYPE_MAP,
> PVR_VM_BIND_TYPE_UNMAP,
> @@ -386,6 +388,7 @@ pvr_vm_gpuva_unmap(struct drm_gpuva_op *op, void
> *op_ctx)
> drm_gpuva_unmap(&op->unmap);
> drm_gpuva_unlink(op->unmap.va);
> + kfree(to_pvr_vm_gpuva(op->unmap.va));
> return 0;
> }
> @@ -433,6 +436,7 @@ pvr_vm_gpuva_remap(struct drm_gpuva_op *op, void
> *op_ctx)
> }
> drm_gpuva_unlink(op->remap.unmap->va);
> + kfree(to_pvr_vm_gpuva(op->remap.unmap->va));
> return 0;
> }
> --
> 2.46.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RESEND] drm/imagination: Free pvr_vm_gpuva after unlink
2024-08-28 13:13 [PATCH] drm/imagination: Free pvr_vm_gpuva after unlink Matt Coster
2024-08-30 14:03 ` Frank Binns
@ 2024-08-30 15:07 ` Matt Coster
2024-09-02 7:57 ` Frank Binns
1 sibling, 1 reply; 4+ messages in thread
From: Matt Coster @ 2024-08-30 15:07 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Frank Binns, dri-devel,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1316 bytes --]
This caused a measurable memory leak. Although the individual
allocations are small, the leaks occurs in a high-usage codepath
(remapping or unmapping device memory) so they add up quickly.
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/imagination/pvr_vm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
index e59517ba039e..97c0f772ed65 100644
--- a/drivers/gpu/drm/imagination/pvr_vm.c
+++ b/drivers/gpu/drm/imagination/pvr_vm.c
@@ -114,6 +114,8 @@ struct pvr_vm_gpuva {
struct drm_gpuva base;
};
+#define to_pvr_vm_gpuva(va) container_of_const(va, struct pvr_vm_gpuva, base)
+
enum pvr_vm_bind_type {
PVR_VM_BIND_TYPE_MAP,
PVR_VM_BIND_TYPE_UNMAP,
@@ -386,6 +388,7 @@ pvr_vm_gpuva_unmap(struct drm_gpuva_op *op, void *op_ctx)
drm_gpuva_unmap(&op->unmap);
drm_gpuva_unlink(op->unmap.va);
+ kfree(to_pvr_vm_gpuva(op->unmap.va));
return 0;
}
@@ -433,6 +436,7 @@ pvr_vm_gpuva_remap(struct drm_gpuva_op *op, void *op_ctx)
}
drm_gpuva_unlink(op->remap.unmap->va);
+ kfree(to_pvr_vm_gpuva(op->remap.unmap->va));
return 0;
}
--
2.46.0
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] drm/imagination: Free pvr_vm_gpuva after unlink
2024-08-30 15:07 ` [PATCH RESEND] " Matt Coster
@ 2024-09-02 7:57 ` Frank Binns
0 siblings, 0 replies; 4+ messages in thread
From: Frank Binns @ 2024-09-02 7:57 UTC (permalink / raw)
To: tzimmermann, Matt Coster, dri-devel, airlied, linux-kernel,
maarten.lankhorst, daniel, mripard
On Fri, 2024-08-30 at 15:07 +0000, Matt Coster wrote:
> This caused a measurable memory leak. Although the individual
> allocations are small, the leaks occurs in a high-usage codepath
> (remapping or unmapping device memory) so they add up quickly.
>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/imagination/pvr_vm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_vm.c b/drivers/gpu/drm/imagination/pvr_vm.c
> index e59517ba039e..97c0f772ed65 100644
> --- a/drivers/gpu/drm/imagination/pvr_vm.c
> +++ b/drivers/gpu/drm/imagination/pvr_vm.c
> @@ -114,6 +114,8 @@ struct pvr_vm_gpuva {
> struct drm_gpuva base;
> };
>
> +#define to_pvr_vm_gpuva(va) container_of_const(va, struct pvr_vm_gpuva, base)
> +
> enum pvr_vm_bind_type {
> PVR_VM_BIND_TYPE_MAP,
> PVR_VM_BIND_TYPE_UNMAP,
> @@ -386,6 +388,7 @@ pvr_vm_gpuva_unmap(struct drm_gpuva_op *op, void *op_ctx)
>
> drm_gpuva_unmap(&op->unmap);
> drm_gpuva_unlink(op->unmap.va);
> + kfree(to_pvr_vm_gpuva(op->unmap.va));
>
> return 0;
> }
> @@ -433,6 +436,7 @@ pvr_vm_gpuva_remap(struct drm_gpuva_op *op, void *op_ctx)
> }
>
> drm_gpuva_unlink(op->remap.unmap->va);
> + kfree(to_pvr_vm_gpuva(op->remap.unmap->va));
>
> return 0;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-02 7:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-28 13:13 [PATCH] drm/imagination: Free pvr_vm_gpuva after unlink Matt Coster
2024-08-30 14:03 ` Frank Binns
2024-08-30 15:07 ` [PATCH RESEND] " Matt Coster
2024-09-02 7:57 ` Frank Binns
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®