* [PATCH 2/2] ARM: dts: qcom: apq8084: add tsens interrupt
2022-09-25 16:13 [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible Luca Weiss
@ 2022-09-25 16:13 ` Luca Weiss
2022-09-26 8:45 ` Neil Armstrong
2022-09-27 12:43 ` Konrad Dybcio
2022-09-26 8:42 ` [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible Neil Armstrong
` (3 subsequent siblings)
4 siblings, 2 replies; 8+ messages in thread
From: Luca Weiss @ 2022-09-25 16:13 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
Add the interrupt for tsens, based on the information from downstream
msm-3.4 dts.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm/boot/dts/qcom-apq8084.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
index defc0602d750..593672f827ed 100644
--- a/arch/arm/boot/dts/qcom-apq8084.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
@@ -264,6 +264,8 @@ tsens: thermal-sensor@fc4a8000 {
nvmem-cells = <&tsens_calib>, <&tsens_backup>;
nvmem-cell-names = "calib", "calib_backup";
#qcom,sensors = <11>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uplow";
#thermal-sensor-cells = <1>;
};
timer@f9020000 {
--
2.37.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] ARM: dts: qcom: apq8084: add tsens interrupt
2022-09-25 16:13 ` [PATCH 2/2] ARM: dts: qcom: apq8084: add tsens interrupt Luca Weiss
@ 2022-09-26 8:45 ` Neil Armstrong
2022-09-27 12:43 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2022-09-26 8:45 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 18:13, Luca Weiss wrote:
> Add the interrupt for tsens, based on the information from downstream
> msm-3.4 dts.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-apq8084.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
> index defc0602d750..593672f827ed 100644
> --- a/arch/arm/boot/dts/qcom-apq8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
> @@ -264,6 +264,8 @@ tsens: thermal-sensor@fc4a8000 {
> nvmem-cells = <&tsens_calib>, <&tsens_backup>;
> nvmem-cell-names = "calib", "calib_backup";
> #qcom,sensors = <11>;
> + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow";
> #thermal-sensor-cells = <1>;
> };
> timer@f9020000 {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] ARM: dts: qcom: apq8084: add tsens interrupt
2022-09-25 16:13 ` [PATCH 2/2] ARM: dts: qcom: apq8084: add tsens interrupt Luca Weiss
2022-09-26 8:45 ` Neil Armstrong
@ 2022-09-27 12:43 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2022-09-27 12:43 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 25.09.2022 18:13, Luca Weiss wrote:
> Add the interrupt for tsens, based on the information from downstream
> msm-3.4 dts.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-apq8084.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
> index defc0602d750..593672f827ed 100644
> --- a/arch/arm/boot/dts/qcom-apq8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
> @@ -264,6 +264,8 @@ tsens: thermal-sensor@fc4a8000 {
> nvmem-cells = <&tsens_calib>, <&tsens_backup>;
> nvmem-cell-names = "calib", "calib_backup";
> #qcom,sensors = <11>;
> + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "uplow";
> #thermal-sensor-cells = <1>;
> };
> timer@f9020000 {
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible
2022-09-25 16:13 [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible Luca Weiss
2022-09-25 16:13 ` [PATCH 2/2] ARM: dts: qcom: apq8084: add tsens interrupt Luca Weiss
@ 2022-09-26 8:42 ` Neil Armstrong
2022-09-26 8:44 ` Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2022-09-26 8:42 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 18:13, Luca Weiss wrote:
> Bindings mandate the use of the fallback compatible qcom,tsens-v0_1 for
> msm8974. Add it to fix the warning.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-apq8084.dtsi | 2 +-
> arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
> index f2fb7c975af8..defc0602d750 100644
> --- a/arch/arm/boot/dts/qcom-apq8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
> @@ -258,7 +258,7 @@ tsens_backup: backup@440 {
> };
>
> tsens: thermal-sensor@fc4a8000 {
> - compatible = "qcom,msm8974-tsens";
> + compatible = "qcom,msm8974-tsens", "qcom,tsens-v0_1";
> reg = <0xfc4a9000 0x1000>, /* TM */
> <0xfc4a8000 0x1000>; /* SROT */
> nvmem-cells = <&tsens_calib>, <&tsens_backup>;
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 7a9be0acf3f5..cf8af99a4864 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1116,7 +1116,7 @@ cnoc: interconnect@fc480000 {
> };
>
> tsens: thermal-sensor@fc4a9000 {
> - compatible = "qcom,msm8974-tsens";
> + compatible = "qcom,msm8974-tsens", "qcom,tsens-v0_1";
> reg = <0xfc4a9000 0x1000>, /* TM */
> <0xfc4a8000 0x1000>; /* SROT */
> nvmem-cells = <&tsens_calib>, <&tsens_backup>;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible
2022-09-25 16:13 [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible Luca Weiss
2022-09-25 16:13 ` [PATCH 2/2] ARM: dts: qcom: apq8084: add tsens interrupt Luca Weiss
2022-09-26 8:42 ` [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible Neil Armstrong
@ 2022-09-26 8:44 ` Krzysztof Kozlowski
2022-09-27 12:42 ` Konrad Dybcio
2022-10-18 3:05 ` (subset) " Bjorn Andersson
4 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 8:44 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 18:13, Luca Weiss wrote:
> Bindings mandate the use of the fallback compatible qcom,tsens-v0_1 for
> msm8974. Add it to fix the warning.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible
2022-09-25 16:13 [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible Luca Weiss
` (2 preceding siblings ...)
2022-09-26 8:44 ` Krzysztof Kozlowski
@ 2022-09-27 12:42 ` Konrad Dybcio
2022-10-18 3:05 ` (subset) " Bjorn Andersson
4 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2022-09-27 12:42 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 25.09.2022 18:13, Luca Weiss wrote:
> Bindings mandate the use of the fallback compatible qcom,tsens-v0_1 for
> msm8974. Add it to fix the warning.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-apq8084.dtsi | 2 +-
> arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
> index f2fb7c975af8..defc0602d750 100644
> --- a/arch/arm/boot/dts/qcom-apq8084.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
> @@ -258,7 +258,7 @@ tsens_backup: backup@440 {
> };
>
> tsens: thermal-sensor@fc4a8000 {
> - compatible = "qcom,msm8974-tsens";
> + compatible = "qcom,msm8974-tsens", "qcom,tsens-v0_1";
> reg = <0xfc4a9000 0x1000>, /* TM */
> <0xfc4a8000 0x1000>; /* SROT */
> nvmem-cells = <&tsens_calib>, <&tsens_backup>;
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 7a9be0acf3f5..cf8af99a4864 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1116,7 +1116,7 @@ cnoc: interconnect@fc480000 {
> };
>
> tsens: thermal-sensor@fc4a9000 {
> - compatible = "qcom,msm8974-tsens";
> + compatible = "qcom,msm8974-tsens", "qcom,tsens-v0_1";
> reg = <0xfc4a9000 0x1000>, /* TM */
> <0xfc4a8000 0x1000>; /* SROT */
> nvmem-cells = <&tsens_calib>, <&tsens_backup>;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: (subset) [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible
2022-09-25 16:13 [PATCH 1/2] ARM: dts: qcom: fix msm8974 tsens compatible Luca Weiss
` (3 preceding siblings ...)
2022-09-27 12:42 ` Konrad Dybcio
@ 2022-10-18 3:05 ` Bjorn Andersson
4 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2022-10-18 3:05 UTC (permalink / raw)
To: luca, linux-arm-msm
Cc: phone-devel, devicetree, linux-kernel, robh+dt, agross,
Krzysztof Kozlowski, ~postmarketos/upstreaming, Konrad Dybcio
On Sun, 25 Sep 2022 18:13:16 +0200, Luca Weiss wrote:
> Bindings mandate the use of the fallback compatible qcom,tsens-v0_1 for
> msm8974. Add it to fix the warning.
>
>
Applied, thanks!
[1/2] ARM: dts: qcom: fix msm8974 tsens compatible
commit: 23fa8ec64963b504071bdd0bdc6ade28cd7ecca1
[2/2] ARM: dts: qcom: apq8084: add tsens interrupt
commit: 078d683252d9ceb06661cd3fc07b6fd58ef06548
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread