mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Joe Perches <joe@perches.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select
Date: Thu, 5 Mar 2020 16:20:20 +0000	[thread overview]
Message-ID: <55edba5c-78d6-12e2-eff6-f16c204badee@huawei.com> (raw)
In-Reply-To: <84f8504924380fc6380216d03d28a2285e3d106e.camel@perches.com>

On 05/03/2020 16:01, Joe Perches wrote:
> On Thu, 2020-03-05 at 15:53 +0000, John Garry wrote:
>> On 05/03/2020 15:15, Joe Perches wrote:
>>> commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash
>>> controller driver") likely inadvertently used a select statement
>>> with a CONFIG_ prefix, remove the prefix.
>>>
>>> Signed-off-by: Joe Perches <joe@perches.com>
>>
>> It's a pity checkpatch can't pick this stuff up...
> 
> You are free to write a rule and submit a patch.
> 

I'm not opposed to the idea...

> The grammar is pretty hard to verify from a patch
> fragment though.
> 
> There are 2 existing nominal false positives.
> 
> $ git grep 'select\b.*\bCONFIG_' -- '*/Kconfig*'
> drivers/edac/Kconfig:     select CONFIG_ACPI_NFIT.
> drivers/edac/Kconfig:     select CONFIG_ACPI_NFIT.

Ah, that's in the help text. I guess that those can be ignored simply 
based on the indentation.

I also see these:

drivers/i2c/busses/Kconfig:       to also select CONFIG_TYPEC_FUSB302=m.
drivers/platform/chrome/Kconfig:        select CONFIG_MFD_CROS_EC_DEV

The 2nd looks like it's incorrect.

And then also:
$ git grep 'depends on\b.*\bCONFIG_' -- '*/Kconfig*'
samples/Kconfig:        depends on CONFIG_ANDROID_BINDERFS

Thanks,
John

  reply	other threads:[~2020-03-05 16:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 15:15 Joe Perches
2020-03-05 15:53 ` John Garry
2020-03-05 16:01   ` Joe Perches
2020-03-05 16:20     ` John Garry [this message]
2020-03-05 16:21       ` Randy Dunlap
2020-03-05 16:38         ` Joe Perches
2020-03-06 15:19 ` Applied "spi: Remove CONFIG_ prefix from Kconfig select" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55edba5c-78d6-12e2-eff6-f16c204badee@huawei.com \
    --to=john.garry@huawei.com \
    --cc=broonie@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®