From: Joe Perches <joe@perches.com>
To: Randy Dunlap <rdunlap@infradead.org>, John Garry <john.garry@huawei.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select
Date: Thu, 05 Mar 2020 08:38:20 -0800 [thread overview]
Message-ID: <e31a520573d20552223a16cf18be0674972a3fb2.camel@perches.com> (raw)
In-Reply-To: <15ad3c68-4e67-0c92-a0e1-c62861673561@infradead.org>
On Thu, 2020-03-05 at 08:21 -0800, Randy Dunlap wrote:
> On 3/5/20 8:20 AM, John Garry wrote:
> > On 05/03/2020 16:01, Joe Perches wrote:
> > > On Thu, 2020-03-05 at 15:53 +0000, John Garry wrote:
> > > > On 05/03/2020 15:15, Joe Perches wrote:
> > > > > commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash
> > > > > controller driver") likely inadvertently used a select statement
> > > > > with a CONFIG_ prefix, remove the prefix.
> > > > >
> > > > > Signed-off-by: Joe Perches <joe@perches.com>
> > > >
> > > > It's a pity checkpatch can't pick this stuff up...
> > >
> > > You are free to write a rule and submit a patch.
> > >
> >
> > I'm not opposed to the idea...
It'd be better I think to update the grammar
verification in the tool that parses these files.
see: scripts/kconfig/...
> > > The grammar is pretty hard to verify from a patch
> > > fragment though.
> > >
> > > There are 2 existing nominal false positives.
> > >
> > > $ git grep 'select\b.*\bCONFIG_' -- '*/Kconfig*'
> > > drivers/edac/Kconfig: select CONFIG_ACPI_NFIT.
> > > drivers/edac/Kconfig: select CONFIG_ACPI_NFIT.
> >
> > Ah, that's in the help text. I guess that those can be ignored simply based on the indentation.
The grammar is per line whitespace independent, so not necessarily.
> > drivers/platform/chrome/Kconfig: select CONFIG_MFD_CROS_EC_DEV
> >
> > The 2nd looks like it's incorrect.
>
> Yes, we just got a patch for that one today.
That's the reason I submitted this one.
next prev parent reply other threads:[~2020-03-05 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 15:15 Joe Perches
2020-03-05 15:53 ` John Garry
2020-03-05 16:01 ` Joe Perches
2020-03-05 16:20 ` John Garry
2020-03-05 16:21 ` Randy Dunlap
2020-03-05 16:38 ` Joe Perches [this message]
2020-03-06 15:19 ` Applied "spi: Remove CONFIG_ prefix from Kconfig select" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e31a520573d20552223a16cf18be0674972a3fb2.camel@perches.com \
--to=joe@perches.com \
--cc=broonie@kernel.org \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®