mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths
       [not found] <cover.1751280932.git.khairul.anuar.romli@altera.com>
@ 2025-06-30 11:00 ` khairul.anuar.romli
  0 siblings, 0 replies; only message in thread
From: khairul.anuar.romli @ 2025-06-30 11:00 UTC (permalink / raw)
  To: Mark Brown, open list:SPI SUBSYSTEM, open list, Matthew Gerlach,
	Khairul Anuar Romli, Dan Carpenter, Santhosh Kumar K

From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>

Remove incorrect checks on cqspi->rx_chan that cause driver breakage
during failure cleanup. Ensure proper resource freeing on the success
path when operating in cqspi->use_direct_mode, preventing leaks and
improving stability.

Fixes: b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
cc: stable@vger.kernel.org # 6.6+
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Changes in v2:
    - Add Fixes tag and stable in cc.
---
 drivers/spi/spi-cadence-quadspi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index aa1932ba17cb..d3c78f59b22c 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
 
 	pm_runtime_enable(dev);
 
-	if (cqspi->rx_chan) {
-		dma_release_channel(cqspi->rx_chan);
-		goto probe_setup_failed;
-	}
-
 	pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
 	pm_runtime_use_autosuspend(dev);
 	pm_runtime_get_noresume(dev);
-- 
2.35.3


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-06-30 11:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1751280932.git.khairul.anuar.romli@altera.com>
2025-06-30 11:00 ` [PATCH v2 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths khairul.anuar.romli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®