* [PATCH] staging: rtl8723bs: clean up identical code on an if statement
@ 2017-04-13 15:46 Colin King
2017-04-14 12:15 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-04-13 15:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Hans de Goede, Larry Finger, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The two different paths for an if statement are identical and hence
we can just replace it with the single statement.
Detected by CoverityScan, CID#1428443 ("Identical code for
different branches")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 53755e5b97a6..9e355734f0c0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -1093,11 +1093,7 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue)
rtw_init_bcmc_stainfo(adapter);
}
- if (lock_scanned_queue) {
- find_network(adapter);
- } else {
- find_network(adapter);
- }
+ find_network(adapter);
if (lock_scanned_queue)
adapter->securitypriv.key_mask = 0;
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: clean up identical code on an if statement
2017-04-13 15:46 [PATCH] staging: rtl8723bs: clean up identical code on an if statement Colin King
@ 2017-04-14 12:15 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2017-04-14 12:15 UTC (permalink / raw)
To: Colin King, Greg Kroah-Hartman, Larry Finger, devel
Cc: kernel-janitors, linux-kernel
Hi,
On 13-04-17 17:46, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The two different paths for an if statement are identical and hence
> we can just replace it with the single statement.
>
> Detected by CoverityScan, CID#1428443 ("Identical code for
> different branches")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 53755e5b97a6..9e355734f0c0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -1093,11 +1093,7 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue)
> rtw_init_bcmc_stainfo(adapter);
> }
>
> - if (lock_scanned_queue) {
> - find_network(adapter);
> - } else {
> - find_network(adapter);
> - }
> + find_network(adapter);
>
> if (lock_scanned_queue)
> adapter->securitypriv.key_mask = 0;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-14 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 15:46 [PATCH] staging: rtl8723bs: clean up identical code on an if statement Colin King
2017-04-14 12:15 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®