From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: qcom-spmi-adc5: Add ADC5_GPIO2_100K_PU
Date: Sat, 8 Jul 2023 16:45:28 +0200 [thread overview]
Message-ID: <560ddda0-338c-533b-35c5-58483ae0cea0@linaro.org> (raw)
In-Reply-To: <20230708152931.146c6944@jic23-huawei>
On 8.07.2023 16:29, Jonathan Cameron wrote:
> On Tue, 27 Jun 2023 03:08:20 +0300
> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:
>
>> On 27/06/2023 02:21, Konrad Dybcio wrote:
>>> Even though it existed in bindings for the longest time,
>>> ADC5_GPIO2_100K_PU was never assigned in the driver. Do so.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>> drivers/iio/adc/qcom-spmi-adc5.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>
> I was a little unsure on this one. So far I've applied it as a 'feature'
> so it's in the normal iio togreg branch, but perhaps it should be a fix?
I suppose it's a feature as it's never been used before
Konrad
>
> For now applied to the togreg branch of iio.git but given I'll be rebasing
> that on rc1, for now it's only visible as testing. 0-day can play with that
> in the meantime and see if it can find any issues
>
> Jonathan
>
>
prev parent reply other threads:[~2023-07-08 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 23:21 Konrad Dybcio
2023-06-27 0:08 ` Dmitry Baryshkov
2023-07-08 14:29 ` Jonathan Cameron
2023-07-08 14:45 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560ddda0-338c-533b-35c5-58483ae0cea0@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®