From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
<linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] tools: Remove conflicting BITS_PER_LONG define
Date: Wed, 19 Sep 2018 14:28:29 +0200 [thread overview]
Message-ID: <562288b4-aac6-182a-6f75-23d32dbdcad5@nokia.com> (raw)
In-Reply-To: <20180912192129.GB13738@kernel.org>
On 12/09/2018 21:21, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 12, 2018 at 04:01:07PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Sep 12, 2018 at 07:02:32PM +0200, Alexander Sverdlin escreveu:
>>> CC .../tools/objtool/builtin-check.o
>>> ...
>>> In file included from .../tools/arch/x86/include/uapi/asm/bitsperlong.h:11:0,
>>> from .../tools/include/asm-generic/bitops/__ffs.h:6,
>>> from .../tools/include/asm-generic/bitops.h:16,
>>> from .../tools/include/linux/bitops.h:35,
>>> from .../tools/include/linux/hashtable.h:13,
>>> from elf.h:24,
>>> from check.h:22,
>>> from builtin-check.c:30:
>>> .../tools/include/asm-generic/bitsperlong.h:8:0: error: "BITS_PER_LONG" redefined [-Werror]
>>> #define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
>>>
>>> Include <asm/bitsperlong.h> instead as other headers do.
>>
>> Please try test building all tools in tools/
>>
>> This broke make -C tools/perf/
>
> Also, where is the build of objtool failing?
I've prepared some examples for you with "-fdirectives-only -save-temps":
This is what happens ultimately:
In file included from .../tools/arch/x86/include/uapi/asm/bitsperlong.h:11:0,
from .../tools/include/asm-generic/bitops/__ffs.h:6,
from .../tools/include/asm-generic/bitops.h:16,
from .../tools/include/linux/bitops.h:35,
from .../tools/include/linux/hashtable.h:13,
from elf.h:24,
from check.h:22,
from builtin-check.c:30:
.../tools/include/asm-generic/bitsperlong.h:8:0: error: "BITS_PER_LONG" redefined [-Werror]
#define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
In file included from .../tools/include/linux/hashtable.h:13:0,
from elf.h:24,
from check.h:22,
from builtin-check.c:30:
.../tools/include/linux/bitops.h:13:0: note: this is the location of the previous definition
# define BITS_PER_LONG __WORDSIZE
And this are relevant parts from builtin-check.i file:
# 1 "builtin-check.c"
# 1 ".../tools/objtool//"
# 1 "<built-in>"
...
#define __SIZEOF_LONG__ 4
...
# 1 ".../sys-root/usr/include/bits/wordsize.h" 1 3 4
...
#define __WORDSIZE 32
...
# 1 ".../sys-root/usr/include/bits/wordsize.h" 1 3 4
...
#define __WORDSIZE 32
...
# 1 ".../sys-root/usr/include/bits/wordsize.h" 1 3 4
...
#define __WORDSIZE 32
...
# 1 ".../sys-root/usr/include/bits/wordsize.h" 1 3 4
...
#define __WORDSIZE 32
...
# 1 ".../tools/include/linux/bitops.h" 1
...
#define BITS_PER_LONG __WORDSIZE
...
# 6 ".../tools/include/asm-generic/bitsperlong.h" 2
...
#define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
It could be that your compiler doesn't define __SIZEOF_LONG__, while my does.
It could be that it's caused by the fact that I'm using a "cross compiler"
(i686 compiler to build x86_64 kernel), maybe I'm just using a newer compiler
than you.
--
Best regards,
Alexander Sverdlin.
next prev parent reply other threads:[~2018-09-19 12:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 17:02 Alexander Sverdlin
2018-09-12 19:01 ` Arnaldo Carvalho de Melo
2018-09-12 19:21 ` Arnaldo Carvalho de Melo
2018-09-19 12:28 ` Alexander Sverdlin [this message]
2018-09-19 13:03 ` Arnaldo Carvalho de Melo
2018-09-19 15:25 ` Alexander Sverdlin
2018-09-24 8:33 ` Alexander Sverdlin
2018-09-19 12:16 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562288b4-aac6-182a-6f75-23d32dbdcad5@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®