From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] tools: Remove conflicting BITS_PER_LONG define
Date: Wed, 19 Sep 2018 14:16:03 +0200 [thread overview]
Message-ID: <822a52db-93f1-3681-29ba-595cd000b5cd@nokia.com> (raw)
In-Reply-To: <20180912190107.GA5502@redhat.com>
On 12/09/2018 21:01, Arnaldo Carvalho de Melo wrote:
>> CC .../tools/objtool/builtin-check.o
>> ...
>> In file included from .../tools/arch/x86/include/uapi/asm/bitsperlong.h:11:0,
>> from .../tools/include/asm-generic/bitops/__ffs.h:6,
>> from .../tools/include/asm-generic/bitops.h:16,
>> from .../tools/include/linux/bitops.h:35,
>> from .../tools/include/linux/hashtable.h:13,
>> from elf.h:24,
>> from check.h:22,
>> from builtin-check.c:30:
>> .../tools/include/asm-generic/bitsperlong.h:8:0: error: "BITS_PER_LONG" redefined [-Werror]
>> #define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
>>
>> Include <asm/bitsperlong.h> instead as other headers do.
> Please try test building all tools in tools/
>
> This broke make -C tools/perf/
I agree, this brakes perf, so we need to work further on that...
--
Best regards,
Alexander Sverdlin.
prev parent reply other threads:[~2018-09-19 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 17:02 Alexander Sverdlin
2018-09-12 19:01 ` Arnaldo Carvalho de Melo
2018-09-12 19:21 ` Arnaldo Carvalho de Melo
2018-09-19 12:28 ` Alexander Sverdlin
2018-09-19 13:03 ` Arnaldo Carvalho de Melo
2018-09-19 15:25 ` Alexander Sverdlin
2018-09-24 8:33 ` Alexander Sverdlin
2018-09-19 12:16 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=822a52db-93f1-3681-29ba-595cd000b5cd@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=acme@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®