mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Greg KH <gregkh@linuxfoundation.org>, punit vara <punitvara@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test
Date: Sun, 18 Oct 2015 21:44:18 -0500	[thread overview]
Message-ID: <56245902.7070202@lwfinger.net> (raw)
In-Reply-To: <20151019020020.GB8496@kroah.com>

On 10/18/2015 09:00 PM, Greg KH wrote:
> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote:
>> One more thing I would like suggestion how can start switching this
>> driver to LIB80211 ,MAC80211 ? Which is the first file I should focus
>> ? Simultaneously I am trying to understand the flow of driver . I
>> would like to know the start point  from where I can start doing small
>> changes.
>
> If you don't understand the wireless stack, I suggest you do some
> research on it first, converting a driver to the in-kernel stack is a
> _very_ difficult thing and not something that someone without any
> experience in this area is going to be able to do easily.

I second this suggestion. Your skill level is not nearly sufficient for this 
sort of task. Note that there is a group working on driver rtl8192su, which 
should be able to replace rtl8712u. The participants are very highly skilled 
wireless developers; however, they are having trouble. The internals of the 
Realtek chips are not revealed to anyone in any form other than the code they 
release.

Larry



  reply	other threads:[~2015-10-19  2:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 18:25 [PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings Punit Vara
2015-10-14 18:25 ` [PATCH RESEND 1/4] Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset() Punit Vara
2015-10-14 18:25 ` [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Punit Vara
2015-10-14 18:25 ` [PATCH RESEND 3/4] Staging: rtl8712: Coding style warnings fix for block comments Punit Vara
2015-10-14 18:25 ` [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test Punit Vara
2015-10-17  5:16   ` Greg KH
2015-10-18  6:32     ` punit vara
2015-10-18 18:54       ` Tillmann Heidsieck
2015-10-18 19:14         ` Tillmann Heidsieck
2015-10-19  2:00       ` Greg KH
2015-10-19  2:44         ` Larry Finger [this message]
2015-10-19 15:21           ` punit vara
2015-10-22 19:04             ` punit vara
2015-10-22 19:14               ` Greg KH
2015-10-22 19:22               ` Dan Carpenter
2015-10-22 20:03                 ` punit vara
2015-10-22 20:34                   ` Dan Carpenter
2015-10-24  7:11                     ` punit vara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56245902.7070202@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=Julia.Lawall@lip6.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=punitvara@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome