Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

[Tillmann Heidsieck <theidsieck@leenox.de>]

Hi,

On 2015-10-18 08:32, punit vara wrote:
> On Sat, Oct 17, 2015 at 10:46 AM, Greg KH <gregkh@linuxfoundation.org> 
> wrote:
>> On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote:
>>> Put constant on the right side of a test.Problem found using 
>>> checkpatch:
>>> 
>>> Warning:Comparisons should place the constant on the right side of 
>>> the test
>>> 
>>> Signed-off-by: Punit Vara <punitvara@gmail.com>
>>> ---
>>>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
>>>  1 file changed, 8 insertions(+), 8 deletions(-)
>> 
>> Didn't apply to my tree :(
> In this case what should I do ? Should I do git reset , git pull and
> then  do changes on latest tree ?
> 

Greg is probably trying to apply this series to the staging-next branch 
of his staging tree[0]
so you need to clone that one, or add it as an additional remote[1] to 
your clone of the kernel tree (much better option IMHO). After this you 
need to rebase[2] your changes onto the stating-next branch, fix up all 
conflicts in your code, and resend the patch.

I hope this helps

Tillmann

[0] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
[1] https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes
[2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git