From: Tingguo Cheng <quic_tingguoc@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: <quic_fenglinw@quicinc.com>, <quic_tingweiz@quicinc.com>,
<kernel@quicinc.com>, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals
Date: Wed, 30 Oct 2024 18:33:41 +0800 [thread overview]
Message-ID: <563e7080-68a9-4735-995a-72baf2e35d49@quicinc.com> (raw)
In-Reply-To: <CAA8EJprYHjYVM58e7i7Sxj64DSth4hhW_cUZ3hGqX7u0ecZFQg@mail.gmail.com>
On 10/28/2024 5:41 PM, Dmitry Baryshkov wrote:
> On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@quicinc.com> wrote:
>>
>>
>>
>> On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
>>> On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
>>>> Enable PMIC and PMIC peripherals for qcs615-ride board.
>>>>
>>>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
>>>> 1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> @@ -6,6 +6,7 @@
>>>>
>>>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>> #include "qcs615.dtsi"
>>>> +#include "pm8150.dtsi"
>>>> / {
>>>> model = "Qualcomm Technologies, Inc. QCS615 Ride";
>>>> compatible = "qcom,qcs615-ride", "qcom,qcs615";
>>>> @@ -210,6 +211,20 @@ &rpmhcc {
>>>> clocks = <&xo_board_clk>;
>>>> };
>>>>
>>>> +&pon {
>>>> + /delete-property/ mode-bootloader;
>>>> + /delete-property/ mode-recovery;
>>>
>>> Why?
>> Because boot modes will be supported on PSCI module from another patch,
>> reboot-modes are required to remove from PMIC side.
>
> => commit message, please.
>
okay, will upload v4 with other comments fixing together.
>>>
>>>> +};
>>>> +
>>>> +&pon_pwrkey {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&pon_resin {
>>>> + linux,code = <KEY_VOLUMEDOWN>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> &uart0 {
>>>> status = "okay";
>>>> };
>>>>
>>>> --
>>>> 2.34.1
>>>>
>>>
>>
>> --
>> Thank you & BRs
>> Tingguo
>>
>
>
--
Thank you & BRs
Tingguo
next prev parent reply other threads:[~2024-10-30 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 8:03 [PATCH v3 0/2] Adds SPMI bus, PMIC and peripherals for qcs615 Tingguo Cheng
2024-10-28 8:03 ` [PATCH v3 1/2] arm64: dts: qcom: qcs615: Adds SPMI support Tingguo Cheng
2024-10-31 20:55 ` Konrad Dybcio
2024-10-28 8:03 ` [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals Tingguo Cheng
2024-10-28 8:23 ` Dmitry Baryshkov
2024-10-28 8:40 ` Tingguo Cheng
2024-10-28 9:41 ` Dmitry Baryshkov
2024-10-28 13:09 ` Konrad Dybcio
2024-10-28 13:14 ` Dmitry Baryshkov
2024-10-31 20:28 ` Elliot Berman
2024-11-05 7:47 ` Tingguo Cheng
2024-11-12 9:42 ` Tingguo Cheng
2024-10-30 10:33 ` Tingguo Cheng [this message]
2024-10-29 2:18 ` Bjorn Andersson
2024-10-29 13:07 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563e7080-68a9-4735-995a-72baf2e35d49@quicinc.com \
--to=quic_tingguoc@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®