From: Ian Abbott <abbotti@mev.co.uk>
To: Ranjith T <ranjithece24@gmail.com>, gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro
Date: Wed, 11 Nov 2015 14:11:50 +0000 [thread overview]
Message-ID: <56434CA6.3000007@mev.co.uk> (raw)
In-Reply-To: <CAEgNZo9pWaxV0DzD7+w5+hQbYL9+3fBf3uv3CO6OEQE3OcEnCg@mail.gmail.com>
On 11/11/2015 13:44, Ranjith T wrote:
> Is this patch is fine?.
>
> Thanks,
> Ranjith T.
Fine apart from the "Signed-off-by" line. I'm guessing your last name
isn't really "T".
> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T <ranjithece24@gmail.com> wrote:
>> BIT macro is used for defining BIT location instead of
>> shifting operator - coding style issue
>>
>> Signed-off-by: Ranjith T <ranjithece24@gmail.com>
>> ---
>> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
>> index 15a4093..1bf8ddc 100644
>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>> @@ -75,8 +75,8 @@
>> #define PARPORT_DATA_REG 0x00
>> #define PARPORT_STATUS_REG 0x01
>> #define PARPORT_CTRL_REG 0x02
>> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>
>> static int parport_data_reg_insn_bits(struct comedi_device *dev,
>> struct comedi_subdevice *s,
>> --
>> 1.7.10.4
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-11-11 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 17:48 Ranjith T
2015-11-11 13:44 ` Ranjith T
2015-11-11 14:11 ` Ian Abbott [this message]
2015-11-11 14:18 ` Ranjith T
2015-11-11 14:36 ` Ian Abbott
-- strict thread matches above, loose matches on Subject: below --
2015-11-11 15:54 Ranjith Thangavel
2015-11-12 17:57 ` Ian Abbott
2015-11-09 15:17 Ranjith
2015-11-09 16:55 ` Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56434CA6.3000007@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®