* [PATCH] mm/compaction: improve comment
@ 2015-11-24 8:23 Yaowei Bai
2015-11-24 15:52 ` Vlastimil Babka
0 siblings, 1 reply; 3+ messages in thread
From: Yaowei Bai @ 2015-11-24 8:23 UTC (permalink / raw)
To: akpm; +Cc: vbabka, iamjoonsoo.kim, riel, mina86, linux-mm, linux-kernel
Make comment more accurate.
Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
mm/compaction.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index de3e1e7..b3cf915 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1708,7 +1708,9 @@ static void compact_nodes(void)
/* The written value is actually unused, all memory is compacted */
int sysctl_compact_memory;
-/* This is the entry point for compacting all nodes via /proc/sys/vm */
+/* This is the entry point for compacting all nodes via
+ * /proc/sys/vm/compact_memory
+ */
int sysctl_compaction_handler(struct ctl_table *table, int write,
void __user *buffer, size_t *length, loff_t *ppos)
{
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/compaction: improve comment
2015-11-24 8:23 [PATCH] mm/compaction: improve comment Yaowei Bai
@ 2015-11-24 15:52 ` Vlastimil Babka
2015-11-25 8:55 ` Yaowei Bai
0 siblings, 1 reply; 3+ messages in thread
From: Vlastimil Babka @ 2015-11-24 15:52 UTC (permalink / raw)
To: Yaowei Bai, akpm; +Cc: iamjoonsoo.kim, riel, mina86, linux-mm, linux-kernel
On 11/24/2015 09:23 AM, Yaowei Bai wrote:
> Make comment more accurate.
Make changelog more descriptive? :)
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> ---
> mm/compaction.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index de3e1e7..b3cf915 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1708,7 +1708,9 @@ static void compact_nodes(void)
> /* The written value is actually unused, all memory is compacted */
> int sysctl_compact_memory;
>
> -/* This is the entry point for compacting all nodes via /proc/sys/vm */
> +/* This is the entry point for compacting all nodes via
> + * /proc/sys/vm/compact_memory
> + */
Strictly speaking, multi-line comments should have a leading empty line,
e.g.:
/*
* This is the entry point ...
> int sysctl_compaction_handler(struct ctl_table *table, int write,
> void __user *buffer, size_t *length, loff_t *ppos)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/compaction: improve comment
2015-11-24 15:52 ` Vlastimil Babka
@ 2015-11-25 8:55 ` Yaowei Bai
0 siblings, 0 replies; 3+ messages in thread
From: Yaowei Bai @ 2015-11-25 8:55 UTC (permalink / raw)
To: Vlastimil Babka
Cc: akpm, iamjoonsoo.kim, riel, mina86, linux-mm, linux-kernel
On Tue, Nov 24, 2015 at 04:52:17PM +0100, Vlastimil Babka wrote:
> On 11/24/2015 09:23 AM, Yaowei Bai wrote:
> >Make comment more accurate.
>
> Make changelog more descriptive? :)
ok
>
> >Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> >---
> > mm/compaction.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> >diff --git a/mm/compaction.c b/mm/compaction.c
> >index de3e1e7..b3cf915 100644
> >--- a/mm/compaction.c
> >+++ b/mm/compaction.c
> >@@ -1708,7 +1708,9 @@ static void compact_nodes(void)
> > /* The written value is actually unused, all memory is compacted */
> > int sysctl_compact_memory;
> >
> >-/* This is the entry point for compacting all nodes via /proc/sys/vm */
> >+/* This is the entry point for compacting all nodes via
> >+ * /proc/sys/vm/compact_memory
> >+ */
>
> Strictly speaking, multi-line comments should have a leading empty
> line, e.g.:
>
> /*
> * This is the entry point ...
Got it, will send an updated one soon. Thanks.
>
>
>
> > int sysctl_compaction_handler(struct ctl_table *table, int write,
> > void __user *buffer, size_t *length, loff_t *ppos)
> > {
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-25 8:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-24 8:23 [PATCH] mm/compaction: improve comment Yaowei Bai
2015-11-24 15:52 ` Vlastimil Babka
2015-11-25 8:55 ` Yaowei Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome