From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<swarren@wwwdotorg.org>
Subject: Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type
Date: Wed, 6 Jan 2016 11:18:07 +0530 [thread overview]
Message-ID: <568CAA97.3080908@nvidia.com> (raw)
In-Reply-To: <20160105174114.GI6588@sirena.org.uk>
On Tuesday 05 January 2016 11:11 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote:
>
>> + d->type_reg_stride = chip->type_reg_stride ? : 1;
>> +
> Please don't abuse the ternery operator, especially not the GCC
> extension - that's much less clear than just writing the if statement.
>
Sure, I will not use this in my future coding.
Thanks for correcting this before applying.
prev parent reply other threads:[~2016-01-06 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 12:55 Laxman Dewangan
2015-12-22 12:55 ` [PATCH 2/2] regmap: irq: add support to have callback pre/post irq handling Laxman Dewangan
2016-01-05 17:43 ` Mark Brown
2016-01-06 6:04 ` Laxman Dewangan
2016-01-05 17:41 ` [PATCH 1/2] regmap: irq: add support for configuration of trigger type Mark Brown
2016-01-06 5:48 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568CAA97.3080908@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome